Create geography_type enum and add geography column in connection table #16818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencecho
changed the title
|
todo: edit name of file to reflect the current oss version |
pmossman
approved these changes
Oct 3, 2022
pmossman
reviewed
Oct 3, 2022
| .execute(); | ||
| } | ||
|
|
||
| private static void addGeographyColumn(final DSLContext ctx) { |
There was a problem hiding this comment.
@terencecho just realized, I think we want all existing connection record to be set to 'AUTO' during this migration, right?
|
@terencecho I started on the API changes that will use this, and I realized we might want to make some changes to this migration before we merge/run it in prod.
Let me know if any of that doesn't make sense or if you wanna chat about it! |
|
@pmossman sounds good to me. i can make those changes on tuesday. |
|
New updates since my last review look good, consider this re-approved! |
This was referenced Oct 5, 2022
letiescanciano
added a commit
that referenced
this pull request
Oct 6, 2022
…vation * master: (26 commits) supply a source id for schema discovery in connector integration tests (#17662) Source Iterable: Add permission check for stream (#17602) Moving TrackingClientSingleton.initialize into the bean itself (#17631) Handle null workspace IDs in tracking/reporting methods gracefully (#17641) Bump Airbyte version from 0.40.11 to 0.40.12 (#17653) Revert "Do not wait the end of a reset to return an update (#17591)" (#17640) Standardize HttpRequester's url_base and path format (#17524) Create geography_type enum and add geography column in connection and workspace table (#16818) airbyte-cron: update connector definitions from remote (#16438) Do not wait the end of a reset to return an update (#17591) Remove redundant title labels from connector specs (#17544) Updated GA4 status support large schema discovery (#17394) 🪟 🐛 Fixes connector checks not properly ending their loading state (#17620) 🪟🧪 [Experiment] add hideOnboarding experiment (#17605) Source Recharge: change releaseStage to GA (#17606) Source Recharge: skip stream if 403 received (#17608) remove sonar-scan workflow (#17609) Mark/tables should be full width on all pages (#17401) Auto fail all workfow if there is a Versioning issue (#17562) ...
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
… workspace table (airbytehq#16818) * init commit of geography_type and column * add schema dump * confirm prod database was meant to be changed * add AUTO to geography * set default and not nullable, also edit workspace table * update version number * update schema dump Co-authored-by: pmossman <parker@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In preparation to support a routing service for jobs to be put in different task queues based off the data planes users want to run them in, this PR creates a geography enum type in the database (currently populated with
AUTO,USandEU) and creates ageographycolumn in the connection table.