🐛Source Hubspot: Fixed 403 error validation #16914

lazebnyi · 2022-09-20T10:30:05Z

What

https://github.com/airbytehq/oncall/issues/526 - Source: HubSpot - requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.hubapi.com/automation/v3/workflows?limit=100 (via Sentry)

When facing forbidden error, the Hubspot source connector just log it. Syncs stop after these errors occur.

How

Handle error and return empty record if error occur.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

bazarnov

Please check the print() statements left inside the code.

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py

lazebnyi · 2022-09-20T15:34:39Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3091443567
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3091443567
🐛 https://gradle.com/s/423esv6taot4u

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/test_associations.py::test_incremental_read_fetches_associations[api_key]
	 FAILED integration_tests/test_associations.py::test_incremental_read_fetches_associations[oauth]
	 �[31m======================= �[31m�[1m2 failed�[0m, �[33m323 warnings�[0m�[31m in 8.75s�[0m�[31m ========================�[0m

…validation

lazebnyi · 2022-09-27T12:53:45Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3135771152
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3135771152
🐛 https://gradle.com/s/qlwvsxginrkk6

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/test_associations.py::test_incremental_read_fetches_associations[api_key]
	 FAILED integration_tests/test_associations.py::test_incremental_read_fetches_associations[oauth]
	 �[31m======================= �[31m�[1m2 failed�[0m, �[33m323 warnings�[0m�[31m in 16.58s�[0m�[31m =======================�[0m

pedroslopez · 2022-09-28T14:56:15Z

@lazebnyi looks like we have some failing tests

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py

…validation

lazebnyi · 2022-10-03T21:52:54Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3177743365
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3177743365
🐛 https://gradle.com/s/2dvr5n4jyoq4g

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
=================== 2 failed, 33 passed in 301.55s (0:05:01) ===================

lazebnyi · 2022-10-03T22:34:49Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3177952615
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/3177952615
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/source.py         90     19    79%
source_hubspot/streams.py       837    202    76%
-------------------------------------------------
TOTAL                          1008    228    77%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       3      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       837     77    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                          1008     98    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

…validation

lazebnyi · 2022-10-03T22:53:30Z

/publish connector=connectors/source-hubspot run-tests=false

🕑 Publishing the following connectors:
connectors/source-hubspot
https://github.com/airbytehq/airbyte/actions/runs/3178038247

Connector	Did it publish?	Were definitions generated?
connectors/source-hubspot	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Fixed 403 error validation * Updated PR number * Updated after review * Updated after review * Updated version * Add ignoredd fields * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Fixed 403 error validation

bdc16c2

lazebnyi requested review from bazarnov and roman-yermilov-gl September 20, 2022 10:30

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 20, 2022

octavia-squidington-iii added the connectors/source/hubspot label Sep 20, 2022

Updated PR number

ad2620e

bazarnov approved these changes Sep 20, 2022

View reviewed changes

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py Outdated Show resolved Hide resolved

Updated after review

e584368

Merge branch 'master' into lazebnyi/526-source-hubspot-fix-403-error-…

55e05fe

…validation

pedroslopez reviewed Sep 28, 2022

View reviewed changes

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py Show resolved Hide resolved

lazebnyi and others added 3 commits October 3, 2022 23:38

Merge branch 'master' into lazebnyi/526-source-hubspot-fix-403-error-…

085293e

…validation

Updated after review

b06ef44

Updated version

0d461fb

Add ignoredd fields

436c0ad

Merge branch 'master' into lazebnyi/526-source-hubspot-fix-403-error-…

1b79c3d

…validation

lazebnyi removed the request for review from roman-yermilov-gl October 3, 2022 23:02

auto-bump connector version [ci skip]

2c84a6e

lazebnyi merged commit 06186d2 into master Oct 3, 2022

lazebnyi deleted the lazebnyi/526-source-hubspot-fix-403-error-validation branch October 3, 2022 23:07

octavia-squidington-iii mentioned this pull request Oct 5, 2022

Bump Airbyte version from 0.40.10 to 0.40.11 #17610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Source Hubspot: Fixed 403 error validation #16914

🐛Source Hubspot: Fixed 403 error validation #16914

lazebnyi commented Sep 20, 2022

bazarnov left a comment

lazebnyi commented Sep 20, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Sep 27, 2022 •

edited by github-actions bot

Loading

pedroslopez commented Sep 28, 2022

lazebnyi commented Oct 3, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Oct 3, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Oct 3, 2022 •

edited by github-actions bot

Loading

🐛Source Hubspot: Fixed 403 error validation #16914

🐛Source Hubspot: Fixed 403 error validation #16914

Conversation

lazebnyi commented Sep 20, 2022

What

How

Pre-merge Checklist

Community member or Airbyter

Airbyter

bazarnov left a comment

Choose a reason for hiding this comment

lazebnyi commented Sep 20, 2022 • edited by github-actions bot Loading

Build Failed

lazebnyi commented Sep 27, 2022 • edited by github-actions bot Loading

Build Failed

pedroslopez commented Sep 28, 2022

lazebnyi commented Oct 3, 2022 • edited by github-actions bot Loading

Build Failed

lazebnyi commented Oct 3, 2022 • edited by github-actions bot Loading

Build Passed

lazebnyi commented Oct 3, 2022 • edited by github-actions bot Loading

lazebnyi commented Sep 20, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Sep 27, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Oct 3, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Oct 3, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Oct 3, 2022 •

edited by github-actions bot

Loading