-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source github: improve error logging #16947
Source github: improve error logging #16947
Conversation
/test connector=connectors/source-github
Build FailedTest summary info:
|
SATs blocked by #16534 |
/test connector=connectors/source-github
Build PassedTest summary info:
|
/publish connector=connectors/source-github
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-github
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* airbytehq#410 oncall source github: improve error logging * source github: upd changelog * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* airbytehq#410 oncall source github: improve error logging * source github: upd changelog * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
When handling http 500 error, we try to log the error message getting it from
response.json()
. Since response is empty, we're failing even earlier than we should.How
Log
response.text
instead