Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec and doc fixes to prepare MySQL Source for Beta #17164

Merged
merged 7 commits into from
Sep 29, 2022
Merged

Spec and doc fixes to prepare MySQL Source for Beta #17164

merged 7 commits into from
Sep 29, 2022

Conversation

grishick
Copy link
Contributor

issue: 17162

What

  • rename JDBC URL Params to JDBC URL Parameters (Advanced) for consistency wth Postgres documentation
  • Add a link to MySQL JDBC URL documentation
  • Fix a broken link in mysql.md

@grishick grishick requested a review from a team as a code owner September 26, 2022 19:36
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 26, 2022
@grishick grishick changed the title Greg/mysql to beta Spec and doc fixes to prepare MySQL Source for Beta Sep 26, 2022
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-mysql-strict-encrypt
  • source-mysql

ryankfu
ryankfu approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@ryankfu ryankfu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

minor question, isn't example usually abbreviated as e.g.? I do see that the same change is in the postgres/spec.json so if anything this change is fine for consistency

@grishick
Copy link
Contributor Author

LGTM

minor question, isn't example usually abbreviated as e.g.? I do see that the same change is in the postgres/spec.json so if anything this change is fine for consistency

Thank you for catching this. I have copied the description from Postgres and by doing so copied the typo as well.

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-mysql
  • source-mysql-strict-encrypt

@grishick grishick requested a review from subodh1810 September 27, 2022 00:38
@Amruta-Ranade
Copy link
Contributor

@ryankfu @grishick "example" is the right usage. "e.g." is engineering-speak and not used in user docs :)

@grishick
Copy link
Contributor Author

@ryankfu @grishick "example" is the right usage. "e.g." is engineering-speak and not used in user docs :)

Thanks Amruta. I changed e.g. to example in the spec file

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-mysql-strict-encrypt
  • source-mysql

@grishick
Copy link
Contributor Author

grishick commented Sep 27, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3139558084
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3139558084
No Python unittests run

Build Passed

Test summary info:

All Passed

@grishick
Copy link
Contributor Author

grishick commented Sep 28, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3146245801
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3146245801
No Python unittests run

Build Passed

Test summary info:

All Passed

@grishick
Copy link
Contributor Author

grishick commented Sep 28, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mysql,connectors/source-mysql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mysql,connectors/source-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3147375256


Connector Did it publish? Were definitions generated?
connectors/source-mysql ✅ ✅
connectors/source-mysql-strict-encrypt ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-mysql
  • source-mysql-strict-encrypt

@grishick grishick linked an issue Sep 28, 2022 that may be closed by this pull request
Certify MySQL Source for Beta #17162
Closed
8 tasks
@grishick grishick merged commit da5df45 into master Sep 29, 2022
@grishick grishick deleted the greg/mysql-to-beta branch September 29, 2022 17:18
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 5, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@grishick @octavia-squidington-iii @jhammarstedt
Spec and doc fixes to prepare MySQL Source for Beta (airbytehq#17164)
bc990d4 
* Fix URL of MySqlSourceDatatypeTest.java

* Fix naming of JDBC URL parameters field to match Postgres

* Fix a typo in JDBC params description

* Bump version to 1.0.0 for beta

* replace e.g. with example

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankfu ryankfu ryankfu approved these changes

@misteryeo misteryeo misteryeo approved these changes

@Amruta-Ranade Amruta-Ranade Awaiting requested review from Amruta-Ranade

@subodh1810 subodh1810 Awaiting requested review from subodh1810

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mysql connectors/source/mysql-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certify MySQL Source for Beta
5 participants
@grishick @Amruta-Ranade @misteryeo @ryankfu @octavia-squidington-iii