🪟 🔧 Add Segment track event to suggested destinations experiment #17328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
timroes
approved these changes
Sep 29, 2022
| @@ -65,6 +68,7 @@ export const DestinationForm: React.FC<DestinationFormProps> = ({ | |||
| actionDescription: "Destination connector type selected", | |||
| connector_destination: connector?.name, | |||
| connector_destination_definition_id: destinationDefinitionId, | |||
| ...(trackParams && { ...trackParams }), | |||
There was a problem hiding this comment.
Suggested change
| ...(trackParams && { ...trackParams }), | |
| ...trackParams, |
You can spread undefined into an object, it will not add anything in that case, thus no need to check if the object existed here.
timroes
suggested changes
Oct 1, 2022
…ations * master: (75 commits) source-sentry: migrate to per-stream states (#17466) Greg/clickhouse polishing (#17483) upgrade debezium version to 1.9.6 (#17459) 🐛 Source Twilio: Lookback_window config (#17478) hide S3 source connector from catalog (#17472) 🪟 Migrate styles for Connection-related Components (#17339) Added new title (#17480) Refactor & convert `PageTitle` to SCSS (#17139) updated releaseStage for zendesk-talk (#17477) [low-code] Apply log level to stream loggers (#17284) 🐛 Source Salesforce: filter out objects not supported by the Bulk API (#17453) Source Marketo: certify GA (#17445) Update greenhouse paginator (#17429) Add some services start validation to acceptance_tests.sh (#17425) 📖 Removes $ from terminal commands to allow direct copying. (#17467) migrate source GA connectors to per-stream states (2) (#17410) Source Klaviyo: bump CDK dependency (#17422) Source Pinterest: change releaseStage to GA (#17045) Source Pinterest: Set start_date dynamically based on API restrictions for lookup (#17387) updated releaseStage to generally_available (#17374) ...
letiescanciano
deleted the
leti/add-segment-track-to-suggested-destinations
branch
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…rbytehq#17328) * Add segment track event to suggested destinations experiment Closes airbytehq#17257 * Fix spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17257
What
We need to measure how the suggested destinations experiment (#16355) performs and we need different params in the track event to be able to do so.
How
connector_destination_suggestedand override default tracking params if the action comes from a featured destination.🚨 User Impact 🚨
No impact