-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure database initialization in test container #17697
Merged
jdpgrailsdev
merged 13 commits into
master
from
jonathan/ensure-db-init-migration-tasks
Oct 13, 2022
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4fbd521
Ensure database initialization in test container
jdpgrailsdev f9fb6ca
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev 301ce3b
Remove unused import
terencecho 4670746
Update schema dump
terencecho 506f377
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev 5e57937
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev 6c6c9de
Add schema dump
jdpgrailsdev 84e49b8
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev 6e23113
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev 49515bc
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev 30c85a5
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev e83decd
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev 6100c93
Merge branch 'master' into jonathan/ensure-db-init-migration-tasks
jdpgrailsdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdpgrailsdev, I think this is incorrect. Each migration dev center should run specific its own init script, i.e. the config migration dev center should only run the configs initial script.
Currently when I run schema dump for one database, it will include the schemas for both configs and jobs database.
The schema dump is still correct in production because it is updated by
ConfigsDatabaseMigratorTest
andJobsDatabaseMigratorTest
, which only does not have this behavior.