[17495] Source-oracle: fixed build and integration test #17769

etsybaev · 2022-10-09T14:11:43Z

What

Currently build and integration tests doesn't work

How

fixed build and integration test

🚨 User Impact 🚨

Only tests affected, no user inpact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…nd-tests

github-actions · 2022-10-09T14:14:09Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-oracle
source-oracle-strict-encrypt

etsybaev · 2022-10-09T14:14:47Z

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/3214430262
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/3214430262
No Python unittests run

Build Passed

Test summary info:

All Passed

etsybaev · 2022-10-09T15:47:47Z

/test connector=connectors/source-oracle-strict-encrypt

🕑 connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3214690448
✅ connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3214690448
No Python unittests run

Build Passed

Test summary info:

All Passed

subodh1810

I dont understand why do we have 2 classes OracleContainer and AirbyteOracteTestContainer

...on/java/io/airbyte/integrations/source/oracle_strict_encrypt/AirbyteOracteTestContainer.java

github-actions · 2022-10-11T18:25:09Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-oracle-strict-encrypt
source-oracle

…nd-tests

etsybaev · 2022-10-11T18:26:38Z

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/3229295194
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/3229295194
No Python unittests run

Build Passed

Test summary info:

All Passed

etsybaev · 2022-10-11T18:26:51Z

/test connector=connectors/source-oracle-strict-encrypt

🕑 connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3229295894
✅ connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3229295894
No Python unittests run

Build Passed

Test summary info:

All Passed

github-actions · 2022-10-11T18:27:28Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-oracle-strict-encrypt
source-oracle

…nd-tests

github-actions · 2022-10-12T08:27:16Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-oracle
source-oracle-strict-encrypt

etsybaev · 2022-10-12T09:43:21Z

No base code was affected (but only tests), so bumping version is not required

) * [17495] Source-oracle: fixed build and integration test

[17495] Source-oracle: fixed build and integration test

1bc1c33

etsybaev requested a review from a team as a code owner October 9, 2022 14:11

github-actions bot added the area/connectors Connector related issues label Oct 9, 2022

octavia-squidington-iv added connectors/source/oracle connectors/source/oracle-strict-encrypt labels Oct 9, 2022

Merge branch 'master' into etsybaev/17495-source-oracle-fixed-build-a…

763b0b4

…nd-tests

airbytehq deleted a comment from github-actions bot Oct 9, 2022

etsybaev mentioned this pull request Oct 10, 2022

Source-oracle: fix build and integration tests #17495

Closed

subodh1810 requested changes Oct 11, 2022

View reviewed changes

...on/java/io/airbyte/integrations/source/oracle_strict_encrypt/AirbyteOracteTestContainer.java Outdated Show resolved Hide resolved

...on/java/io/airbyte/integrations/source/oracle_strict_encrypt/AirbyteOracteTestContainer.java Outdated Show resolved Hide resolved

grishick linked an issue Oct 11, 2022 that may be closed by this pull request

Source-oracle: fix build and integration tests #17495

Closed

[17495] Source-oracle: fixed build and integration test

2f66e0d

Merge branch 'master' into etsybaev/17495-source-oracle-fixed-build-a…

c61d388

…nd-tests

etsybaev requested a review from subodh1810 October 11, 2022 19:12

subodh1810 approved these changes Oct 11, 2022

View reviewed changes

Merge branch 'master' into etsybaev/17495-source-oracle-fixed-build-a…

38179ed

…nd-tests

etsybaev merged commit 0abeff9 into master Oct 12, 2022

etsybaev deleted the etsybaev/17495-source-oracle-fixed-build-and-tests branch October 12, 2022 09:43

This was referenced Oct 13, 2022

Bump Airbyte version from 0.40.14 to 0.40.15 #17961

Closed

Bump Airbyte version from 0.40.14 to 0.40.15 #17970

Merged

jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022

[17495] Source-oracle: fixed build and integration test (airbytehq#17769

05c9e97

) * [17495] Source-oracle: fixed build and integration test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17495] Source-oracle: fixed build and integration test #17769

[17495] Source-oracle: fixed build and integration test #17769

etsybaev commented Oct 9, 2022 •

edited

Loading

github-actions bot commented Oct 9, 2022

etsybaev commented Oct 9, 2022 •

edited by github-actions bot

Loading

etsybaev commented Oct 9, 2022 •

edited by github-actions bot

Loading

subodh1810 left a comment

github-actions bot commented Oct 11, 2022

etsybaev commented Oct 11, 2022 •

edited by github-actions bot

Loading

etsybaev commented Oct 11, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Oct 11, 2022

github-actions bot commented Oct 12, 2022

etsybaev commented Oct 12, 2022

[17495] Source-oracle: fixed build and integration test #17769

[17495] Source-oracle: fixed build and integration test #17769

Conversation

etsybaev commented Oct 9, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

github-actions bot commented Oct 9, 2022

etsybaev commented Oct 9, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Oct 9, 2022 • edited by github-actions bot Loading

Build Passed

subodh1810 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2022

etsybaev commented Oct 11, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Oct 11, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Oct 11, 2022

github-actions bot commented Oct 12, 2022

etsybaev commented Oct 12, 2022

etsybaev commented Oct 9, 2022 •

edited

Loading

etsybaev commented Oct 9, 2022 •

edited by github-actions bot

Loading

etsybaev commented Oct 9, 2022 •

edited by github-actions bot

Loading

etsybaev commented Oct 11, 2022 •

edited by github-actions bot

Loading

etsybaev commented Oct 11, 2022 •

edited by github-actions bot

Loading