🪟 🔧 Ignore classnames during jest snapshot comparison #17773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
changed the title
josephkmh
approved these changes
Oct 10, 2022
letiescanciano
added a commit
that referenced
this pull request
Oct 10, 2022
…vation * master: (22 commits) Update full-refresh-append.md (#17784) Update full-refresh-overwrite.md (#17783) Update incremental-append.md (#17785) Update incremental-deduped-history.md (#17786) Update cdc.md (#17787) 🪟 🔧 Ignore classnames during jest snapshot comparison (#17773) feat: replace openjdk with amazoncorretto:17.0.4 on connectors for seсurity compliance (#17511) Start testing buildpulse. (#17712) Add missing types to the registry (#17763) jobs db descriptions (#16543) config db data catalog (#16427) Update lowcode docs (#17752) db migrations to support new webhook operations (#17671) Bump Airbyte version from 0.40.13 to 0.40.14 (#17762) September Release Notes (#17754) Revert "Use java-datadog-tracer-base image (#17625)" (#17759) Add connection migrations for schema changes (#17651) Connection Form Refactor - Part Two (#16748) Improve E2E testing around the Connection Form (#17577) Bump strict encrypt version (#17747) ...
This was referenced Oct 13, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Ignore classnames during jest snapshot comparison * Replace by simple placeholder * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This changes the jest tests to ignore class names during snapshot comparison.
Previously when using jest's
toMatchSnapshot()method on a@testing-library/reactoutput, we'd compare the whole DOM tree, which included CSS classnames which where minified from SASS modules. Changing CSS could lead to classnames in completely unrelated files getting a new hash and thus those file's tests would fail on completely unrelated PRs. See https://github.com/airbytehq/airbyte/pull/17582/files for an example whereFrequentlyUsedDestinationsandStartWithDestinationtests failed despite those component had no changes at all.How
There is unfortunately no built-in way to Jest or testing-library to ignore specific properties in snapshot testing. Thus I added a custom plugin for snapshot serialization, that will be used whenever a
RenderResult(the result oftesting-library/reactrendermethod) is tried to be snapshotted.That plugin will then clone the whole DOM tree that should be snapshotted and modify each class name in it to be redacted to just the count of classnames that the element had (e.g.
<2 classnames>).Also it's now enough to just pass in the
RenderResultdirectly to theexpectand no longer required to call theasFragment()on it.Why the many changes in the snapshots?
As a result of no longer using
asFragment(), but theRenderResultdirectly, the wrapping elements of the snapshot are now<body><div>instead of<DocumentFragement>which caused all snapshots to change (besides the change inclassthat this PR intended to do).