Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing extraInitContainers #17781

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

czuares
Copy link
Contributor

@czuares czuares commented Oct 10, 2022

What

extraInitContainers are mentioned in the chart README as being available for:

  • airbyte-bootloader
  • server
  • temporal
  • webapp

However, this feature is only present in the temporal template.

How

This PR adds the missing conditional templates for the extraInitContainers to the remaining charts.

Recommended reading order

  1. helm

🚨 User Impact 🚨

The impact would be including initContainers that were previously added but were not present.

Pre-merge Checklist

N/A

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/platform issues related to the platform kubernetes labels Oct 10, 2022
@marcosmarxm marcosmarxm requested a review from xpuska513 October 11, 2022 11:11
Copy link
Contributor

@xpuska513 xpuska513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xpuska513 xpuska513 merged commit c49980a into airbytehq:master Oct 13, 2022
@czuares czuares deleted the extraInitContainers branch October 13, 2022 16:25
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants