-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: GoCardless #17792
🎉 New Source: GoCardless #17792
Conversation
Please sign the CLA @isaacharrisholt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, but look good!
gocardless_environment: | ||
title: Gocardless API Environment | ||
type: string | ||
pattern: "^(live|sandbox)$" | ||
description: | | ||
Environment you are trying to connect to. Should be either `live` or | ||
`sandbox`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we transform this to enum with live
and sandbox
options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Though I must say I couldn't find enum
in the connector spec reference. Maybe I'm blind, but it would be nice if the docs had full-text search :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, there isn't anything there. The docs must be updated.
before this date will not be replicated. | ||
examples: | ||
- '2017-01-25T00:00:00Z' | ||
lookback_window_days: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@girarda this parameter is used internally for the low-code cdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a relic from a previous version of this connector I had running. I just forgot to remove it. That has now been done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
I signed it yesterday, but the CLA Assistant seems to disagree. Here's evidence: |
@isaacharrisholt sometimes people submit the code using other account/email from the local configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small details, overall lgtm!
@@ -0,0 +1,45 @@ | |||
documentationUrl: https://docsurl.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change to https://docs.airbyte.com/integrations/sources/gocardless ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
- access_token | ||
- gocardless_environment | ||
- gocardless_version | ||
- start_date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 spaces 👮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
after changing the 2 last comments I think this contribution is ready to merge! |
/publish connector=connectors/source-gocardless run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
@RealChrisSean another one! :) |
Noted! |
* Initial commit * Reformat JSON * Remove block from acceptance test yaml * Remove references to lookback_window_days * Make gocardless_environment an enum * Add ordering to spec * Address final comments * Make commit to change email associated with PR * Revert previous * add seed config * add docs * auto-bump connector version Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Airbyte supports retrieving data from payment providers such as Stripe, but not GoCardless, a payment provider for direct debit transactions. This is data that can be crucial for financial reconciliation and forecasting.
How
This PR uses the lowcode CDK to create a GoCardless connector with the following streams:
payments
refunds
mandates
payouts
The goal is to add more in the future.
Recommended reading order
gocardless.yaml
spec.yaml
configured_catalog.json
🚨 User Impact 🚨
No changes to existing code.
Pre-merge Checklist
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Integration
Acceptance