Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🧹 Remove connection and mode prop drilling on connection view/edit pages #17808

Merged
merged 9 commits into from
Oct 14, 2022
Merged

🪟 🧹 Remove connection and mode prop drilling on connection view/edit pages #17808

merged 9 commits into from
Oct 14, 2022

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Oct 10, 2022 •
edited
Loading

What

closes #17341
closes #15609

  • Migrates additional pages and components within the Connection workflows to utilize the Service(s)
  • Fixes a bug where connection creation/edit forms were validating on blur and on change

Recommended reading order

  1. *Tab.tsx
  2. ConnectionItemPage.tsx
  3. other

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 10, 2022
@teallarson teallarson marked this pull request as ready for review October 10, 2022 23:49
@teallarson teallarson requested a review from a team as a code owner October 10, 2022 23:49
@teallarson teallarson force-pushed the teal/remove-prop-drilling-connections branch from 5c1f60b to 81937f1 Compare October 11, 2022 14:08
@edmundito
Copy link
Contributor

Overall, the changes are looking great. Just noticed a couple things mentioned in the review comments.

@teallarson teallarson force-pushed the teal/remove-prop-drilling-connections branch 2 times, most recently from 0fd0250 to 537feab Compare October 12, 2022 13:33
@teallarson teallarson requested a review from edmundito October 12, 2022 14:02
edmundito
edmundito approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some light testing to ensure that the pages render as expected and some basic testing of transformation/normalization updates.

@teallarson teallarson force-pushed the teal/remove-prop-drilling-connections branch from 364542f to 5f4cd72 Compare October 14, 2022 13:26
@teallarson teallarson merged commit 22c55b5 into master Oct 14, 2022
@teallarson teallarson deleted the teal/remove-prop-drilling-connections branch October 14, 2022 16:25
@josephkmh josephkmh mentioned this pull request Oct 19, 2022
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 20, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@teallarson @jhammarstedt
🪟 🧹 Remove connection and mode prop drilling on connection view/edit …
16f7815 
…pages (airbytehq#17808)

* normalization field to scss and remove mode

* remove instances of mode and connection being passed

* connectionsettingstab tests pass

* fix validation on blur/validation on change

* redo broken snapshot

* add validateOnBlur back

* cleanup, migrate transformation tab to scss modules

* update snapshot after rebase

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundito edmundito edmundito approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
2 participants
@teallarson @edmundito