Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Add Datadog support to webapp, cleanup sentry init #17821

Merged
merged 8 commits into from
Oct 12, 2022
Merged

🪟 🔧 Add Datadog support to webapp, cleanup sentry init #17821

merged 8 commits into from
Oct 12, 2022

Conversation

edmundito
Copy link
Contributor

@edmundito edmundito commented Oct 11, 2022 •
edited
Loading

What

Related to: https://github.com/airbytehq/airbyte-cloud/issues/2996

Add Datadog Real User Monitoring (RUM) support to app. Update Sentry to lazy import if configuration is available.

https://docs.datadoghq.com/real_user_monitoring/browser/

How

  • Add Datadog utility file and support window variables
  • Try loading Datadog on app startup
  • Move sentry loading to its own file for tidyness

Recommended reading order

airbyte-webapp/src/index.tsx
airbyte-webapp/src/utils/datadog.ts
airbyte-webapp/src/utils/sentry.ts

@edmundito edmundito requested a review from a team as a code owner October 11, 2022 09:22
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 11, 2022
@edmundito edmundito mentioned this pull request Oct 11, 2022
Closed
@edmundito edmundito requested a review from timroes October 11, 2022 15:13
@edmundito edmundito changed the title 🪟 🔧 Add Datadog support to webapp, update Sentry to lazy import 🪟 🔧 Add Datadog support to webapp, cleanup sentry init Oct 11, 2022
timroes
timroes approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Have not tested locally, but seen the logs in the datadog UI. Good to merge as long as we've validated that our Datadog plan allows us to use this in OSS and we know that our quotas are still fitting.

@edmundito edmundito merged commit 7c919e0 into master Oct 12, 2022
@edmundito edmundito deleted the edmundito/add-datadog-rum-v2 branch October 12, 2022 15:35
This was referenced Oct 13, 2022
Closed
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@edmundito @jhammarstedt
🪟 🔧 Add Datadog support to webapp, cleanup sentry init (airbytehq#17821)
c8f973b 
* Add support for Datadog Real User Monitoring (RUM)

* Move sentry init to its own util

* loadDatadogRum -> initDatadogRum

* Move comment back to app index

* Lazy load Sentry and Datadog

* Update version value for Datadog to match Sentry

* Switch process.env with window for sentry and datadog init

* Remove import optimizations from Sentry and Datadog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundito @timroes