Source Recharge: do not call response.json() when handling http errors

[davydov-d]

What

https://github.com/airbytehq/oncall/issues/733

How

Do not call response.json() when trying to decide whether we need to retry a request:

• the response may be empty an result in a json parse error
• we do not actually need it

[davydov-d]

/test connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/3227334438
❌ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/3227334438
🐛 https://gradle.com/s/ccaonkkpeb24q

Build Failed

Test summary info:

Could not find result summary

[davydov-d]

/test connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/3227418094
✅ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/3227418094
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_recharge/source.py        23      0   100%
source_recharge/__init__.py       2      0   100%
source_recharge/api.py           86      5    94%
-------------------------------------------------
TOTAL                           111      5    95%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

[davydov-d]

/publish connector=connectors/source-recharge

🕑 Publishing the following connectors:
connectors/source-recharge
https://github.com/airbytehq/airbyte/actions/runs/3227557575

Connector	Did it publish?	Were definitions generated?
connectors/source-recharge	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[alafanechere]

@davydov-d I already fixed it with this PR: #17822
But your unit test addition is great! Do you mind rebasing on master so we can only keep the tests?

[davydov-d]

@davydov-d I already fixed it with this PR: #17822 But your unit test addition is great! Do you mind rebasing on master so we can only keep the tests?

@alafanechere thanks, sure. done