Source Github: Use default behaviour, retry on 429 and all 5XX errors #17852

grubberr · 2022-10-11T17:01:14Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Try to fix https://github.com/airbytehq/oncall/issues/768

I see some mess: It's not clear what HTTP status we re-try and what we don't retry.
As for me, airbyte_cdk defaults are pretty good. Of course, we also need to retry on rate-limit headers.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-10-11T17:01:52Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3228767375
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3228767375
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/utils.py              14      0   100%
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/graphql.py           145      1    99%
source_github/streams.py           791     44    94%
source_github/source.py            104     27    74%
----------------------------------------------------
TOTAL                             9863     72    99%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-10-11T20:04:09Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3229883511
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3229883511
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/utils.py              14      0   100%
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/graphql.py           145      1    99%
source_github/streams.py           792     44    94%
source_github/source.py            104     27    74%
----------------------------------------------------
TOTAL                             9864     72    99%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

grubberr · 2022-10-12T07:33:38Z

/publish connector=connectors/source-github

🕑 Publishing the following connectors:
connectors/source-github
https://github.com/airbytehq/airbyte/actions/runs/3232848857

Connector	Did it publish?	Were definitions generated?
connectors/source-github	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

grubberr · 2022-10-12T08:03:18Z

/publish connector=connectors/source-github

🕑 Publishing the following connectors:
connectors/source-github
https://github.com/airbytehq/airbyte/actions/runs/3233023460

Connector	Did it publish?	Were definitions generated?
connectors/source-github	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…airbytehq#17852) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

SERVICE_UNAVAILABLE added

25c3881

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-assigned this Oct 11, 2022

github-actions bot added the area/connectors Connector related issues label Oct 11, 2022

octavia-squidington-iv added the connectors/source/github label Oct 11, 2022

grubberr added 3 commits October 11, 2022 21:54

test_should_retry added

2bdd3e4

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

use upstream should_retry

53012d5

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

backoff_time updated

7c2a0ad

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr changed the title ~~Source Github: improve 503 handling for issue_reactions stream~~ Source Github: improve retry handling Oct 11, 2022

grubberr changed the title ~~Source Github: improve retry handling~~ Source Github: Use default behaviour, retry on 429 and all 5XX errors Oct 11, 2022

github.md updated

47640a5

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 11, 2022

grubberr requested review from arsenlosenko and davydov-d October 11, 2022 20:09

grubberr added 2 commits October 11, 2022 23:11

Merge branch 'master' into grubberr/oncall-768-source-github

da10702

Retry-After int -> str in tests

0cb584c

arsenlosenko approved these changes Oct 12, 2022

View reviewed changes

auto-bump connector version [ci skip]

a445c28

grubberr merged commit 8e6fb79 into master Oct 12, 2022

grubberr deleted the grubberr/oncall-768-source-github branch October 12, 2022 08:35

This was referenced Oct 13, 2022

Bump Airbyte version from 0.40.14 to 0.40.15 #17961

Closed

Bump Airbyte version from 0.40.14 to 0.40.15 #17970

Merged

jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022

Source Github: Use default behaviour, retry on 429 and all 5XX errors (…

b6d5b13

…airbytehq#17852) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Github: Use default behaviour, retry on 429 and all 5XX errors #17852

Source Github: Use default behaviour, retry on 429 and all 5XX errors #17852

grubberr commented Oct 11, 2022 •

edited

Loading

grubberr commented Oct 11, 2022 •

edited by github-actions bot

Loading

grubberr commented Oct 11, 2022 •

edited by github-actions bot

Loading

grubberr commented Oct 12, 2022 •

edited by github-actions bot

Loading

grubberr commented Oct 12, 2022 •

edited by github-actions bot

Loading

Source Github: Use default behaviour, retry on 429 and all 5XX errors #17852

Source Github: Use default behaviour, retry on 429 and all 5XX errors #17852

Conversation

grubberr commented Oct 11, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Oct 11, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Oct 11, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Oct 12, 2022 • edited by github-actions bot Loading

grubberr commented Oct 12, 2022 • edited by github-actions bot Loading

grubberr commented Oct 11, 2022 •

edited

Loading

grubberr commented Oct 11, 2022 •

edited by github-actions bot

Loading

grubberr commented Oct 11, 2022 •

edited by github-actions bot

Loading

grubberr commented Oct 12, 2022 •

edited by github-actions bot

Loading

grubberr commented Oct 12, 2022 •

edited by github-actions bot

Loading