Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse existing ports for test; fix flaky test #17856

Merged
merged 1 commit into from
Oct 11, 2022
Merged

reuse existing ports for test; fix flaky test #17856

merged 1 commit into from
Oct 11, 2022

Conversation

colesnodgrass
Copy link
Member

What

  • fix flaky test

How

  • reuse known ports instead of potentially fetching new ones

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Oct 11, 2022
jdpgrailsdev
jdpgrailsdev approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: assuming the Kube acceptance tests pass.

@colesnodgrass colesnodgrass temporarily deployed to more-secrets October 11, 2022 20:32 Inactive
@colesnodgrass colesnodgrass merged commit bd54de0 into master Oct 11, 2022
@colesnodgrass colesnodgrass deleted the cole/reuse-same-ports branch October 11, 2022 21:10
This was referenced Oct 13, 2022
Closed
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@colesnodgrass @jhammarstedt
reuse existing ports for test (airbytehq#17856)
41512dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @jdpgrailsdev