Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth Field should be required #17867

Closed
wants to merge 1 commit into from
Closed

OAuth Field should be required #17867

wants to merge 1 commit into from

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Oct 12, 2022 •
edited
Loading

What

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 12, 2022
@teallarson teallarson changed the title update isAuthFlowSelected to match authSpecification pattern OAuth Field should be required Oct 12, 2022
@teallarson
Copy link
Contributor Author

NOTE: after pairing with Tim, this looks like an issue with useBuildForm and how it generates a "new schema" that it is somehow no longer requiring the fields if the connector follows the authSpecification pattern rather than the advancedAuth pattern. I'm pausing working on this while @timroes looks a bit into that.

@teallarson
Copy link
Contributor Author

teallarson commented Oct 14, 2022 •
edited
Loading

@timroes has identified a number of issues with our OAuth flow that he is working on. They are linked to #17753

Closing this PR in favor of those.

@teallarson teallarson closed this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teallarson