Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source: Amazon Ads : update amazon-ads version to 0.1.23 #17870

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

ganpatagarwal
Copy link
Contributor

What

*Update version to 0.1.23

How

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 12, 2022
@ganpatagarwal ganpatagarwal changed the title update amazon-ads version to 0.1.23 🐛 Source: Amazon Ads : update amazon-ads version to 0.1.23 Oct 12, 2022
@sajarin sajarin self-requested a review October 12, 2022 18:26
@sajarin sajarin merged commit ca198ec into airbytehq:master Oct 12, 2022
@grishick
Copy link
Contributor

@ganpatagarwal @sajarin this is not how publishing new versions works. You have to run a publish command, which publishes the new image version to DockerHub and updates the version in yaml files. See the documentation in the checklist in the description of the issue and here: https://docs.airbyte.com/connector-development/#updating-an-existing-connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants