remove usages of YamlSeedConfigPersistence #17895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroslopez
commented
Oct 12, 2022
| @@ -33,6 +33,8 @@ | |||
| */ | |||
| final public class LocalDefinitionsProvider implements DefinitionsProvider { | |||
|
|
|||
| public static final Class<?> DEFAULT_SEED_DEFINITION_RESOURCE_CLASS = SeedType.class; | |||
There was a problem hiding this comment.
This is the change that cloud needs in order for it to fully remove its usages of YamlSeedConfigPersistence and we can delete it safely.
evantahler
approved these changes
Oct 12, 2022
gosusnp
approved these changes
Oct 13, 2022
This was referenced Oct 13, 2022
letiescanciano
added a commit
that referenced
this pull request
Oct 14, 2022
…vation * master: (98 commits) 🐛 Source Bing Ads - Fix Campaigns stream misses Audience and Shopping (#17873) Source S3 - fix schema inference (#17991) 🎉 JDBC sources: store cursor record count in db state (#15535) Introduce webhook configs into workspace api and persistence (#17950) ci: upload test results to github for analysis (#17953) Trigger the connectors build if there are worker changes. (#17976) Add additional sync timing information (#17643) Use page_token_option instead of page_token (#17892) capture metrics around json messages size (#17973) 🐛 Correct kube annotations variable as per the docs. (#17972) 🪟 🎉 Add /connector-builder page with embedded YAML editor (#17482) fix `est_num_metrics_emitted_by_reporter` not being emitted (#17929) Update schema dumps (#17960) Remove the bump in the value.yml (#17959) Ensure database initialization in test container (#17697) Remove typo line from incremental reads docs (#17920) DocS: Update authentication.md (#17931) Use MessageMigration for Source Connection Check. (#17656) fixed links (#17949) remove usages of YamlSeedConfigPersistence (#17895) ...
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes usages of YamlSeedConfigPersistence and replaces them with LocalDefinitionsProvider and the adapter when necessary. We need to do this before removing the class itself because Cloud is still depending on some of this.
A follow up PR will remove the class.
part of #17844
How
After this PR, YamlSeedConfigPersistence is only used in the definition for the class and its tests.