Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc_update_oath_issue_gsc #17967

Merged
merged 4 commits into from
Oct 18, 2022
Merged

doc_update_oath_issue_gsc #17967

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cac7e55
doc_update_oath_issue_gsc
YowanR Oct 13, 2022
6252cc1
Updated wording
YowanR Oct 13, 2022
14e876f
Merge branch 'master' into YowanR-GCS-OAuthNote
YowanR Oct 13, 2022
0f1e262
Fixed wording for this connector
YowanR Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/integrations/sources/google-search-console.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ This page contains the setup guide and reference information for the google sear

* Credentials to a Google Service Account \(or Google Service Account with delegated Domain Wide Authority\) or Google User Account

:::note

Google has depreciated [some OAuth workflows](https://developers.google.com/identity/protocols/oauth2/resources/oob-migration) that might impact you. We are in the process of working on a fix at the connector-level. Thank you for your patience!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change depreciated > deprecated
Delete "Thank you for your patience!"
Do we have a timeline for the fix? Also, do we have a workaround/alternative for now?
Are other connectors affected by this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No timeline and as far as we know, this only impacts GSC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, if we don't have a timeline for the fix, we shouldn't mention it in docs. How about "Google has deprecated certain OAuth workflows. Before you use this connector, verify that the deprecated workflows don't impact your setup."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are working on a fix (GL backlog) but we don't have an official timeline as we don't fully understand the scope yet. Note that the OAuth deprecation affects our connector (in other word, customers are impacted as a result of an issue on our side, not their side) so I don't think we can ask them to check their workflows. Do you have some other suggestions on how we can best convey this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. In that case, I think we need to give users actionable guidance and ask them to use the alternative method (Service Account, I think?)
How about "Since Google has deprecated certain OAuth workflows, OAuth isn't supported for this connector." And then remove all OAuth-related content from the doc for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amruta! I think that's fair for now. Can we say "Since Google has deprecated certain OAuth workflows, OAuth isn't supported for this connector at this time.". We are working on a fix so we don't want to give the impression that this is permanent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sounds good!


:::


## Setup guide
### Step 1: Set up google search console
Expand Down