Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octavia CLI uses Basic Auth #17982

Merged
merged 11 commits into from
Oct 18, 2022
Merged

Octavia CLI uses Basic Auth #17982

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
658ae35
[WIP] Octavia CLI uses Basic Auth
evantahler Oct 13, 2022
35f516c
readme
evantahler Oct 13, 2022
d7d73b6
augustin: add basic auth headers to clien
alafanechere Oct 14, 2022
2b2c949
augustin: add basic auth headers to client
alafanechere Oct 14, 2022
7b25951
tests passing
evantahler Oct 14, 2022
5e59afd
lint
evantahler Oct 14, 2022
bc91545
docs
evantahler Oct 14, 2022
17f07f9
Move monkey patch to test
evantahler Oct 17, 2022
348aefe
coerce headers into strings
evantahler Oct 17, 2022
4ad020f
monkey patch get_basic_auth_token
alafanechere Oct 18, 2022
4702844
Merge branch 'evan/nginx-auth' into evan/octavia-for-basic-auth
evantahler Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions octavia-cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ docker-compose run octavia-cli <command>`
| **Flag** | **Description** | **Env Variable** | **Default** |
| ---------------------------------------- | --------------------------------------------------------------------------------- | -------------------------- | ------------------------------------------------------ |
| `--airbyte-url` | Airbyte instance URL. | `AIRBYTE_URL` | `http://localhost:8000` |
| `--airbyte-username` | Airbyte instance username (basic auth). | `AIRBYTE_URL` | `airbyte` |
| `--airbyte-password` | Airbyte instance password (basic auth). | `AIRBYTE_URL` | `password` |
| `--workspace-id` | Airbyte workspace id. | `AIRBYTE_WORKSPACE_ID` | The first workspace id found on your Airbyte instance. |
| `--enable-telemetry/--disable-telemetry` | Enable or disable the sending of telemetry data. | `OCTAVIA_ENABLE_TELEMETRY` | True |
| `--api-http-header` | HTTP Header value pairs passed while calling Airbyte's API | None | None |
Expand Down Expand Up @@ -690,7 +692,7 @@ $ octavia apply
3. Activate the virtualenv: `source .venv/bin/activate`.
4. Install dev dependencies: `pip install -e .\[tests\]`.
5. Install `pre-commit` hooks: `pre-commit install`.
6. Run the unittest suite: `pytest --cov=octavia_cli`.
6. Run the unittest suite: `pytest --cov=octavia_cli`. Note, a local version of airbyte needs to be running (e.g. `docker compose up` from the root directory of the project)
7. Make sure the build passes (step 0) before opening a PR.

## Telemetry
Expand All @@ -709,7 +711,8 @@ You can disable telemetry by setting the `OCTAVIA_ENABLE_TELEMETRY` environment

| Version | Date | Description | PR |
| ------- | ---------- | ------------------------------------------------------------------------------------- | ----------------------------------------------------------- |
| 0.40.14 | 2022-08-10 | Enable cron and basic scheduling | [#15253](https://github.com/airbytehq/airbyte/pull/15253) |
| 0.41.0 | 2022-10-13 | Use Basic Authentication for making API requests | [#17982](https://github.com/airbytehq/airbyte/pull/17982) |
| 0.40.14 | 2022-08-10 | Enable cron and basic scheduling | [#15253](https://github.com/airbytehq/airbyte/pull/15253) |
| 0.39.33 | 2022-07-05 | Add `octavia import all` command | [#14374](https://github.com/airbytehq/airbyte/pull/14374) |
| 0.39.32 | 2022-06-30 | Create import command to import and manage existing Airbyte resource from octavia-cli | [#14137](https://github.com/airbytehq/airbyte/pull/14137) |
| 0.39.27 | 2022-06-24 | Create get command to retrieve resources JSON representation | [#13254](https://github.com/airbytehq/airbyte/pull/13254) |
Expand Down
Loading