Skip CHECKs steps if previous sync success #17999

andriikorotkov · 2022-10-14T15:40:45Z

What

Skip CHECKs steps if previous sync success

How

First sync:

Second success sync after first success sync:

Second sync (first failure attempt) after first success sync:

Second sync (second success attempt) after first failure attempt (Please do not look at changing some of the logs, I just forgot to put them back when I took the screenshots =)):

Second success sync after first failure sync:

🚨 User Impact 🚨

Skip CHECKs steps if previous sync success

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…vious attempt is failure

…13459_skip_checks_steps_if_connecton_success

andriikorotkov · 2022-10-14T15:55:25Z

All I have to do is add new ones and update some existing tests.

evantahler

Nice! I think you are well on the right path. Learning about Temporal is tricky - well done!

evantahler · 2022-10-14T17:24:06Z

...o/airbyte/workers/temporal/scheduling/activities/JobCreationAndStatusUpdateActivityImpl.java

+    configTypes.add(SYNC);
+
+    try {
+      List<Job> jobList = jobPersistence.listJobsIncludingId(configTypes, input.getConnectionId().toString(), input.getJobId(), limit);


To confirm: limit will query SQL for 2 rows, but are we ordering by the right thing to get the most recent 2 attempts?

Good question. Judging by the way the structure of the method for obtaining jobs is built, the first request will be to get OffsetDateTime of creation of an active job. With the second request, we will receive the number of jobs whose creation date is greater than or equal to the result of the first request. Since we make a request with the identifier of the last active job, the number we will receive from the second request will always be 1. And then, during the calculation, we will receive the number of jobs that will be returned to us for processing - this will be calculated based on the result of the second request, and the limit we passed to this request - the result will always be 2.

…method

…13459_skip_checks_steps_if_connecton_success

evantahler · 2022-10-17T15:27:47Z

Removing myself from the PR review and adding some folks from the Platform Workflow team

benmoriceau · 2022-10-17T15:36:02Z

...kers/src/main/java/io/airbyte/workers/temporal/scheduling/ConnectionManagerWorkflowImpl.java

-    if (isResetJob(sourceLauncherConfig) || checkFailure.isFailed()) {
+    final JobCheckFailureInput jobStateInput =
+        new JobCheckFailureInput(Long.parseLong(jobRunConfig.getJobId()), jobRunConfig.getAttemptId().intValue(), connectionId);
+    var isLastJobOrAttemptFailure = jobCreationAndStatusUpdateActivity.isLastJobOrAttemptFailure(jobStateInput);


You need to create a new workflow version here. Otherwise it will make the running workflow to fail when this is being deploy. The workflow version is a temporal internal functionality that ensure compatibility between an old running version of this workflow and the new one you are trying to introduce. You canfind an example of the usage of such a version on line 287 in the report success function. I will be happy to pair on this if needed.

Another issue here is that you need to wrap your activity code in the runMandatoryActivityWithOutput function. This is needed to ensure that we don't block the workflow is this activity fails for any reason.

I believe that for the version comment the test WorkflowReplayingTest should fail as of now.

@benmoriceau, I added the changes you posted above. But I'm not sure if I did it right because I failed to update the version correctly. Please review my pull request again and if I'm doing something wrong, tell me what I should add and change. (I'm working with temporal for the first time, and I may be wrong in something)

…13459_skip_checks_steps_if_connecton_success � Conflicts: � airbyte-workers/src/main/java/io/airbyte/workers/temporal/scheduling/activities/JobCreationAndStatusUpdateActivityImpl.java

...kers/src/main/java/io/airbyte/workers/temporal/scheduling/ConnectionManagerWorkflowImpl.java

benmoriceau

LGTM, let's wait for the build to pass to make sure that the workflowReplayerTest is passing.

…13459_skip_checks_steps_if_connecton_success

* Disabled CHECKs for source and destination, when previous sync or previous attempt is failure * added tests and added minor changes to the isLastJobOrAttemptFailure method * updated remarks * updated code style * updated code style * fixed remarks * fixed remarks

andriikorotkov added 2 commits October 14, 2022 18:11

Disabled CHECKs for source and destination, when previous sync or pre…

bb0870e

…vious attempt is failure

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

971b7d5

…13459_skip_checks_steps_if_connecton_success

github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Oct 14, 2022

andriikorotkov requested review from evantahler, pedroslopez, tuliren, alafanechere and DoNotPanicUA October 14, 2022 15:41

andriikorotkov changed the title ~~Skip CHECKs steps if connection success~~ Skip CHECKs steps if previous sync success Oct 14, 2022

andriikorotkov linked an issue Oct 14, 2022 that may be closed by this pull request

Only run CHECKs after a failing Sync attempt #13459

Closed

evantahler reviewed Oct 14, 2022

View reviewed changes

added tests and added minor changes to the isLastJobOrAttemptFailure …

9c593c3

…method

andriikorotkov requested a review from evantahler October 17, 2022 14:01

andriikorotkov marked this pull request as ready for review October 17, 2022 14:01

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

bcd9686

…13459_skip_checks_steps_if_connecton_success

andriikorotkov temporarily deployed to more-secrets October 17, 2022 14:05 Inactive

evantahler requested review from benmoriceau and gosusnp and removed request for evantahler October 17, 2022 15:28

benmoriceau requested changes Oct 17, 2022

View reviewed changes

updated remarks

9ab1786

andriikorotkov temporarily deployed to more-secrets October 19, 2022 11:52 Inactive

andriikorotkov added 2 commits October 19, 2022 15:26

updated code style

73f8a87

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

42d1353

…13459_skip_checks_steps_if_connecton_success � Conflicts: � airbyte-workers/src/main/java/io/airbyte/workers/temporal/scheduling/activities/JobCreationAndStatusUpdateActivityImpl.java

andriikorotkov temporarily deployed to more-secrets October 19, 2022 12:29 Inactive

updated code style

928e1cf

andriikorotkov temporarily deployed to more-secrets October 19, 2022 12:53 Inactive

benmoriceau requested changes Oct 19, 2022

View reviewed changes

...kers/src/main/java/io/airbyte/workers/temporal/scheduling/ConnectionManagerWorkflowImpl.java Outdated Show resolved Hide resolved

fixed remarks

ddefab4

andriikorotkov requested a review from benmoriceau October 19, 2022 15:05

andriikorotkov temporarily deployed to more-secrets October 19, 2022 15:06 Inactive

benmoriceau approved these changes Oct 19, 2022

View reviewed changes

benmoriceau requested changes Oct 19, 2022

View reviewed changes

...kers/src/main/java/io/airbyte/workers/temporal/scheduling/ConnectionManagerWorkflowImpl.java Outdated Show resolved Hide resolved

fixed remarks

310847f

andriikorotkov requested a review from benmoriceau October 19, 2022 16:31

andriikorotkov temporarily deployed to more-secrets October 19, 2022 16:32 Inactive

benmoriceau approved these changes Oct 19, 2022

View reviewed changes

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

e66126f

…13459_skip_checks_steps_if_connecton_success

andriikorotkov temporarily deployed to more-secrets October 20, 2022 07:13 Inactive

andriikorotkov merged commit e62c3c3 into master Oct 20, 2022

andriikorotkov deleted the akorotkov/13459_skip_checks_steps_if_connecton_success branch October 20, 2022 09:26

octavia-squidington-iii mentioned this pull request Oct 20, 2022

Bump Airbyte version from 0.40.15 to 0.40.16 #18268

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip CHECKs steps if previous sync success #17999

Skip CHECKs steps if previous sync success #17999

andriikorotkov commented Oct 14, 2022 •

edited

Loading

andriikorotkov commented Oct 14, 2022

evantahler left a comment

evantahler Oct 14, 2022 •

edited

Loading

andriikorotkov Oct 17, 2022

evantahler commented Oct 17, 2022

benmoriceau Oct 17, 2022

benmoriceau Oct 17, 2022

andriikorotkov Oct 19, 2022

benmoriceau left a comment

Skip CHECKs steps if previous sync success #17999

Skip CHECKs steps if previous sync success #17999

Conversation

andriikorotkov commented Oct 14, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

andriikorotkov commented Oct 14, 2022

evantahler left a comment

Choose a reason for hiding this comment

evantahler Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

andriikorotkov Oct 17, 2022

Choose a reason for hiding this comment

evantahler commented Oct 17, 2022

benmoriceau Oct 17, 2022

Choose a reason for hiding this comment

benmoriceau Oct 17, 2022

Choose a reason for hiding this comment

andriikorotkov Oct 19, 2022

Choose a reason for hiding this comment

benmoriceau left a comment

Choose a reason for hiding this comment

andriikorotkov commented Oct 14, 2022 •

edited

Loading

evantahler Oct 14, 2022 •

edited

Loading