Loosen state check #18003
Closed
Loosen state check #18003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoriceau
reviewed
Oct 14, 2022
| } | ||
|
|
||
| // Verify that actual contains expected all the (key, value) from expected. | ||
| private void assertStateContains(final JsonNode expected, final JsonNode actual) { |
There was a problem hiding this comment.
I don't understand why we allow extra.
There was a problem hiding this comment.
Maybe let's merge it to unlock Michael but we should revisit and also make sure that the platform is buildfor any change to the PG connectors
There was a problem hiding this comment.
#15535 add new fields to the state, if possible, it would be nice to not have a hard check on the exact content of the state in the platform.
mfsiega-airbyte
approved these changes
Oct 14, 2022
|
Holding off to this in favor of #18005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In
testSyncAfterUpgradeToPerStreamState, only check some expected keys as it is not relevant to have to maintain the whole expected state from a connector in that part of our test suite.