include webhook configs in operations db persistence layer #18030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davinchia
reviewed
Oct 15, 2022
There was a problem hiding this comment.
Nice catch.
I think we should edit https://github.com/airbytehq/airbyte/blob/master/airbyte-config/config-persistence/src/test/java/io/airbyte/config/persistence/MockData.java#L402 to have a webhook test case as well.
This would have caught this in the previous PR.
davinchia
approved these changes
Oct 15, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…#18030) * include webhook configs in operations db persistence layer * add unit tests for operations persistence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make sure the webhook configs are included in the db persistence layer.
This was missing from #17984, preventing the new operation type from actually being used.