Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎨 Improve empty state of resource pages #18066

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Oct 17, 2022

What

This changes the wording of the buttons in the empty resource view slighty, to be more actionable (Synced with Natalie around the wording for those) to get us towards eventually removing the separate onboarding page. The new wording is now:

  • Connection: "Create your first connection"
  • Source: "Connect your first source"
  • Destination: "Connect your first destination"

screenshot-20221017-182423

How

  • Move the button label into a property and specify it in the parent components. In genreal we should try passing through actual translated strings or <FormattedMessage/> components instead of passing through ids or even generate them inside the component, so we can eventually get closer to actually validate them statically (see https://github.com/airbytehq/airbyte-internal-issues/issues/588).
  • Moved the bowtie image into the component folder since it's only used there, in accordance to our plan of not having assets in public anymore.

@timroes timroes added team/platform-move area/frontend Related to the Airbyte webapp labels Oct 17, 2022
@timroes timroes requested a review from a team as a code owner October 17, 2022 16:19
@github-actions github-actions bot added the area/platform issues related to the platform label Oct 17, 2022
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code - LGTM
(Not tested locally)

@timroes timroes changed the title Improve empty state of resource pages 🪟 🎨 Improve empty state of resource pages Oct 19, 2022
@timroes timroes merged commit df858a5 into master Oct 19, 2022
@timroes timroes deleted the tim/improve-empty-states branch October 19, 2022 12:52
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Transfer WIP to other machine

* Move bowtie image into component folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/platform-move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants