🎉 Enhanced error messaging for DB source connectors #18087
Conversation
akashkulk
changed the title
|
NOTE
|
|
NOTE
|
|
NOTE
|
|
NOTE
|
|
/test connector=all
Build FailedTest summary info: |
|
NOTE
|
|
/test connector=connectors/source-mysql
Build PassedTest summary info: |
|
/test connector=connectors/source-postgres
Build PassedTest summary info: |
|
/test connector=connectors/source-mysql-strict-encrypt
Build PassedTest summary info: |
|
/test connector=connectors/source-postgres-strict-encrypt
Build PassedTest summary info: |
|
/test connector=connectors/source-mssql
Build FailedTest summary info: |
|
/test connector=connectors/source-oracle
Build PassedTest summary info: |
|
/test connector=connectors/source-tidb
Build PassedTest summary info: |
|
/test connector=connectors/source-cockroachdb
Build PassedTest summary info: |
|
/test connector=connectors/source-mssql
Build PassedTest summary info: |
|
/test connector=connectors/source-mssql-strict-encrypt
Build PassedTest summary info: |
|
NOTE
|
|
/publish connector=connectors/source-mysql run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=connectors/source-mysql-strict-encrypt run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
NOTE
|
|
/publish connector=connectors/source-postgres run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=connectors/source-postgres-strict-encrypt run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=connectors/source-mssql run-tests=false |
|
/publish connector=connectors/source-mssql-strict-encrypt run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
NOTE
|
|
NOTE
|
|
/publish connector=connectors/source-mssql run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
NOTE
|
| Exceptions.toRuntime(this::close); | ||
| LOGGER.info("Closed database connection pool."); | ||
| }); | ||
| } catch (final Exception exception) { |
There was a problem hiding this comment.
Is this logic of surfacing an AirbyteTraceMessage something that can be tested within PostgresSourceTest.java, MysqlSourceTest.java, etc? It seems there's already a test within PostgresSourceTest.java`
* Enhanced error messaging for invalid cursor state * Handle SSH config fail * Handle SSH config fail * Update AbstractDbSource.java * Bump up versions + doc for beta+ connectors Bump up versions + doc for beta+ connectors * auto-bump connector version * auto-bump connector version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Closes https://github.com/airbytehq/oncall/issues/717, https://github.com/airbytehq/alpha-beta-issues/issues/357, https://github.com/airbytehq/alpha-beta-issues/issues/347
Closes https://github.com/airbytehq/oncall/issues/720
check()method in an SshWrappedSource throws an exception when there is a config error. Ideally, the exception should be caught and populated in the correspondingAirbyteConnectionStatusmessageHow
For the InvalidCursorException case : a new case AirbyteTraceMessage system-error is emitted in this case. This can be augmented to handle different error case : enhanced user messaging mappings
The exception is caught and populated in the corresponding
AirbyteConnectionStatusmessage🚨 User Impact 🚨
New, more enhanced error message :
Old :
"Something went wrong in this connector. Please check the logs for more details"
New :
https://www.loom.com/i/18fdf9220d894fc99dcf0283e12ea655