Sentry Integration : Stop reporting all non system-error error types. #18133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/connectors
|
NOTE
|
|
Closing #18132 in favor of this PR! |
|
NOTE
|
|
NOTE
|
|
NOTE
|
evantahler
approved these changes
Oct 18, 2022
...job-persistence/src/main/java/io/airbyte/persistence/job/errorreporter/JobErrorReporter.java
Outdated
Show resolved
Hide resolved
Exclude list of unsupported failure reasons
pedroslopez
approved these changes
Oct 18, 2022
...job-persistence/src/main/java/io/airbyte/persistence/job/errorreporter/JobErrorReporter.java
Outdated
Show resolved
Hide resolved
ryankfu
reviewed
Oct 18, 2022
...persistence/src/test/java/io/airbyte/persistence/job/errorreporter/JobErrorReporterTest.java
Show resolved
Hide resolved
ryankfu
approved these changes
Oct 18, 2022
letiescanciano
added a commit
that referenced
this pull request
Oct 19, 2022
* master: (304 commits) Bump helm chart version reference to 0.40.27 (#18152) Bump helm chart version reference to 0.40.26 (#18094) Update deployment.yaml (#18151) Publishes Postgres, MySQL, MSSQL source with changes from #18041 (#18086) Fix minor DBT Cloud Errors. (#18147) Sentry Integration : Stop reporting all non system-error error types. (#18133) Docs: Fix backoff stategy docs (#18143) 🐛 Destination GCS: Fix error logs to log 'Gcs' rather than 'AWS' (#17901) Add openAPI spec for Connector Builder Server (#17535) Alex/mvp UI for dbt cloud integration (#18095) increased timeout for sat tests (#18128) Bmoric/remove dep connector worker (#17977) `recordsRead` should be a long (#18123) doc_update_oath_issue_gsc (#17967) 🎉 Source Zendesk Chat: engagements data fix infinity looping + gradlew format (#18121) 🐛 Source Zendesk Chat: engagements data fix infinity looping (#17745) Custom APM Tracing (#17947) 11679 BigQuery-Denormalized Destination: improve code coverage (#17827) increased timeout for sat tests (#18114) docs: clarify language (#18090) ...
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…airbytehq#18133) * Sentry Integration : Stop reporting all non system-error error types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18131
As part of the improving connector customer experience workstream, we want to emit config-error traces in discover/read (any place that can fail when a config can be changed) instead of throwing an exception and have that be a system-error by default.
These errors will now be attributed as config-errors with a relevant message to the user. As a result, we'd like to stop sending these to Sentry (which is currently only used for creating GH issues)