Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: Bump airbyte-cdk~=0.2.0 #18174

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

grubberr
Copy link
Contributor

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Oct 19, 2022

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3283427851
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3283427851
No Python unittests run

Build Passed

Test summary info:

All Passed

@grubberr grubberr self-assigned this Oct 19, 2022
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-greenhouse
  • source-mailchimp
  • source-facebook-pages
  • source-recharge
  • source-airtable
  • source-strava
  • source-facebook-marketing
  • source-amazon-sqs
  • source-paystack
  • source-okta
  • source-outreach
  • source-monday
  • source-amplitude
  • source-commercetools
  • source-lever-hiring
  • source-salesloft
  • source-pinterest
  • source-github
  • source-chargebee
  • source-salesforce
  • source-gitlab
  • source-retently
  • source-youtube-analytics
  • source-freshservice
  • source-onesignal
  • source-surveymonkey
  • source-drift
  • source-quickbooks-singer
  • source-klaviyo
  • source-notion
  • source-iterable
  • source-linnworks
  • source-asana
  • source-openweather
  • source-pardot
  • source-amazon-seller-partner
  • source-delighted
  • source-tplcentral
  • source-instagram
  • source-zendesk-sunshine
  • source-sendgrid
  • source-confluence
  • source-twilio
  • source-braintree
  • source-azure-table
  • source-google-search-console
  • source-plaid
  • source-freshcaller
  • source-amazon-ads
  • source-zenloop
  • source-lemlist
  • source-harvest
  • source-appsflyer
  • source-mailgun
  • source-posthog
  • source-cart
  • source-sentry
  • source-prestashop
  • source-zendesk-talk
  • source-freshsales
  • source-google-ads
  • source-pipedrive

@grubberr
Copy link
Contributor Author

grubberr commented Oct 19, 2022

/publish connector=bases/source-acceptance-test

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3283768217


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr merged commit c9f79e6 into master Oct 19, 2022
@grubberr grubberr deleted the grubberr/sat-airbyte-cdk-0.2.0 branch October 19, 2022 18:05
@alafanechere
Copy link
Contributor

alafanechere commented Oct 20, 2022

@grubberr most of our connectors depends on airbyte-cdk~=0.1 .
If SAT gets installed in the same virtualenv as the connector dependencies will clash...

I would suggest also updating connectors dependencies to airbyte-cdk~=0.2

@grubberr
Copy link
Contributor Author

@alafanechere yes we decided to update version of CDK and SAT because of new stream caching
to fix this just need to update setup.py

MAIN_REQUIREMENTS = ["airbyte-cdk~=0.2.0"

MAIN_REQUIREMENTS = ["airbyte-cdk~=0.2.0", "pendulum~=2.1.2", "sgqlc"]

jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants