Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🧹 Move CatalogTree from views to components/connection #18185

Merged
merged 1 commit into from
Oct 20, 2022
Merged

🪟 🧹 Move CatalogTree from views to components/connection #18185

merged 1 commit into from
Oct 20, 2022

Conversation

edmundito
Copy link
Contributor

What

Related to #17823

Moves CatalogTree to the new file structure location from views/CatalogTree to components/connection/CatalogTree

Recommended reading order

Top to bottom

@edmundito edmundito added team/platform-move area/frontend Related to the Airbyte webapp labels Oct 19, 2022
@edmundito edmundito requested a review from a team as a code owner October 19, 2022 20:40
@github-actions github-actions bot added the area/platform issues related to the platform label Oct 19, 2022
josephkmh
josephkmh approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

One question: what else will go in components/connection? Would it make sense to have components/ConnectionForm where CatalogTree is then also located as a sub-component?

@edmundito
Copy link
Contributor Author

@josephkmh Yes, everything related to connection will eventually go in components/connection. Right now I'm only moving the catalog tree because I am making changes for our new feature but plan to move the rest in the future in #17155

@edmundito edmundito merged commit 762c4bd into master Oct 20, 2022
@edmundito edmundito deleted the edmundito/move-catalogtree branch October 20, 2022 14:19
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 20, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@edmundito @jhammarstedt
Move CatalogTree from views to components/connection (airbytehq#18185)
45cf688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephkmh josephkmh josephkmh approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/platform-move
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundito @josephkmh