Ensure we have protocol version on actor def reads #18206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosusnp
requested review from
colesnodgrass,
jdpgrailsdev,
benmoriceau and
alovew
jdpgrailsdev
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
I really wish that we could mix in a SupportsProtocolVersion interface to apply to the StandardSourceDefinition and StandardDestinationDefinition to reduce the code duplication. Perhaps at some point we need to revisit the consolidation of the two into Actors to help with this, but definitely way out of the scope of this PR.
benmoriceau
approved these changes
Oct 20, 2022
|
@jdpgrailsdev, I agree, consolidating sounds like a good idea, one thing on my list for some down time refactoring. |
colesnodgrass
approved these changes
Oct 20, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Ensure we have protocol version on actor def reads * Fix null ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Connectors that have not been updated for a long time may not have a protocol version which can lead to some issues.
This is probably a corner case for older deploys but worth protecting.
How
Make sure we at least have a default version when reading actor defs.