Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source intercom: switch on airbyte-cdk=0.2.0 #18216

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Source intercom: switch on airbyte-cdk=0.2.0 #18216

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c1fd2a
remove vcr
grubberr Oct 20, 2022
1998372
Merge branch 'master' into grubberr/source-intercom-airbyte-cdk-0.2.0
grubberr Oct 20, 2022
6edb511
intercom.md updated
grubberr Oct 20, 2022
1d68ecc
auto-bump connector version
octavia-squidington-iii Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-intercom/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ COPY source_intercom ./source_intercom
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.27
LABEL io.airbyte.version=0.1.28
LABEL io.airbyte.name=airbyte/source-intercom
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-intercom/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from setuptools import find_packages, setup

MAIN_REQUIREMENTS = [
"airbyte-cdk~=0.1",
"airbyte-cdk~=0.2.0",
]

TEST_REQUIREMENTS = [
Expand Down
11 changes: 0 additions & 11 deletions airbyte-integrations/connectors/source-intercom/source_intercom/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
from urllib.parse import parse_qsl, urljoin, urlparse

import requests
import vcr
import vcr.cassette as Cassette
from airbyte_cdk.logger import AirbyteLogger
from airbyte_cdk.sources import AbstractSource
from airbyte_cdk.sources.streams import Stream
Expand Down Expand Up @@ -136,15 +134,6 @@ class IncrementalIntercomSearchStream(IncrementalIntercomStream):
sort_order = "ascending"
use_cache = True

def request_cache(self) -> Cassette:
"""
Override the default `request_cache` method, due to `match_on` is different for POST requests.
We should check additional criteria like ['query', 'body'] instead of default ['uri', 'method']
"""
match_on = ["uri", "query", "method", "body"]
cassette = vcr.use_cassette(self.cache_filename, record_mode="new_episodes", serializer="yaml", match_on=match_on)
return cassette

@stream_state_cache.cache_stream_state
def request_params(self, **kwargs) -> MutableMapping[str, Any]:
"""
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/intercom.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ The Intercom connector should not run into Intercom API limitations under normal

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :-------------------------------------------------------------------------------------------- |
| 0.1.28 | 2022-10-20 | [18216](https://github.com/airbytehq/airbyte/pull/18216) | Use airbyte-cdk~=0.2.0 with SQLite caching |
| 0.1.27 | 2022-08-28 | [17326](https://github.com/airbytehq/airbyte/pull/17326) | Migrate to per-stream states. |
| 0.1.26 | 2022-08-18 | [16540](https://github.com/airbytehq/airbyte/pull/16540) | Fix JSON schema |
| 0.1.25 | 2022-08-18 | [15681](https://github.com/airbytehq/airbyte/pull/15681) | Update Intercom API to v 2.5 |
Expand Down