Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove airbyte-queue #18250

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Remove airbyte-queue #18250

merged 3 commits into from
Oct 20, 2022

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Oct 20, 2022 •
edited
Loading

I think I found more dead code!
Tests pass, so 🪀

@evantahler evantahler temporarily deployed to more-secrets October 20, 2022 16:07 Inactive
@evantahler evantahler temporarily deployed to more-secrets October 20, 2022 17:48 Inactive
@evantahler evantahler temporarily deployed to more-secrets October 20, 2022 19:59 Inactive
@evantahler evantahler temporarily deployed to more-secrets October 20, 2022 21:12 Inactive
@evantahler evantahler marked this pull request as ready for review October 20, 2022 22:03
davinchia
davinchia approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I spoke to Charles about deleting this a while back so onboard!

cgardens
cgardens approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rip

@evantahler evantahler merged commit 7fcadf4 into master Oct 20, 2022
@evantahler evantahler deleted the evan/remove-airbyte-queue branch October 20, 2022 23:02
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 21, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@evantahler @jhammarstedt
Remove airbyte-queue (airbytehq#18250)
1c8827f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

@cgardens cgardens cgardens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evantahler @cgardens @davinchia