Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates getPrivateKeyPair to throw exception when private key pair does not exist #18263

Merged
merged 10 commits into from
Oct 21, 2022
Merged

Updates getPrivateKeyPair to throw exception when private key pair does not exist #18263

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0afe002
Changes method from returning null to throwing Exception to match met…
ryankfu Oct 20, 2022
ea97c72
Added javadoc explaining that KeyPair should not be returning null
ryankfu Oct 20, 2022
16fa02b
Moved ConnectionErrorException to commons package
ryankfu Oct 20, 2022
a60b701
Adds error handling for SshWrappedDestinations and markdown to includ…
ryankfu Oct 21, 2022
d6932e5
Bumps version numbers for Postgres, MySQL, MSSQL
ryankfu Oct 21, 2022
5450f6d
auto-bump connector version
octavia-squidington-iii Oct 21, 2022
76d9ab5
auto-bump connector version
octavia-squidington-iii Oct 21, 2022
bb3620c
Merge branch 'ryan/add-error-messaging-null-private-key-pair' of http…
octavia-squidington-iii Oct 21, 2022
ddb534c
auto-bump connector version
octavia-squidington-iii Oct 21, 2022
bf8d49a
Merge branch 'ryan/add-error-messaging-null-private-key-pair' of http…
octavia-squidington-iii Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ntegrations/bases/base-java/src/main/java/io/airbyte/integrations/base/ssh/SshTunnel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ KeyPair getPrivateKeyPair() throws IOException, GeneralSecurityException {
if (keyPairs != null && keyPairs.iterator().hasNext()) {
return keyPairs.iterator().next();
}
return null;
throw new GeneralSecurityException("Unable to load private key pairs, please verify key pairs are properly inputted");
rodireich marked this conversation as resolved.
Show resolved Hide resolved
}

private String validateKey() {
Expand Down