Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable basic auth for Octavia integration tests #18270

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

evantahler
Copy link
Contributor

Just like #18255 and #18245

@evantahler evantahler changed the title Skip basic auth for Octavia integration tests Disable basic auth for Octavia integration tests Oct 20, 2022
@evantahler evantahler marked this pull request as ready for review October 20, 2022 20:35
@evantahler evantahler temporarily deployed to more-secrets October 20, 2022 20:36 Inactive
@evantahler
Copy link
Contributor Author

evantahler commented Oct 20, 2022

CC @supertopher -
These 3 PRs are the result of tests that timeout appearing as "skipped" in Github rather than "Failed". My bad.

Perhaps we could make timeouts scarier? Is that a good idea?

@supertopher
Copy link
Contributor

thats probably a good idea. ty Evan

@supertopher
Copy link
Contributor

@evantahler can you provide me with a link to those tasks where the timeout hit and the action was skipped?

@evantahler
Copy link
Contributor Author

evantahler commented Oct 20, 2022

@supertopher Here's the main example: #17694

Here's the UI:
Screen Shot 2022-10-20 at 1 47 03 PM

The hard part was that I knew the test that ❌ was flaky, and knew to ignore that one... I just missed the rest

@evantahler
Copy link
Contributor Author

In this PR - Airbyte CI / Platform Kubernetes E2E Test Report (push) seems like a flaky failure, as these changes have nothing to do with it. I'm merging these changes anyway.

@evantahler evantahler merged commit e232ffa into master Oct 20, 2022
@evantahler evantahler deleted the evna/fix-octavia-integration-test branch October 20, 2022 21:10
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants