Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic auth to load_test script #18273

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Add basic auth to load_test script #18273

merged 1 commit into from
Oct 20, 2022

Conversation

pmossman
Copy link
Contributor

What

Now that OSS deployments of Airbyte use basic auth, update the load_test script to source .env and use the BASIC_AUTH_USERNAME/BASIC_AUTH_PASSWORD values when curling the API

@pmossman pmossman requested a review from xiaohansong October 20, 2022 21:22
@pmossman pmossman temporarily deployed to more-secrets October 20, 2022 21:24 Inactive
@pmossman pmossman merged commit c5336ce into master Oct 20, 2022
@pmossman pmossman deleted the parker/load-test-auth branch October 20, 2022 22:06
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 21, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@pmossman @jhammarstedt
use basic auth username and password from .env (airbytehq#18273)
c33c503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaohansong xiaohansong xiaohansong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmossman @xiaohansong