Update docs for local webapp development and basic auth #18288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add note to disable basic auth when developing the UI locally
github-actions
bot
added
the
area/documentation
josephkmh
commented
Oct 21, 2022
|
|
||
| ```bash | ||
| docker-compose stop webapp | ||
| BASIC_AUTH_USERNAME="" BASIC_AUTH_PASSWORD="" docker-compose up | ||
| ``` |
There was a problem hiding this comment.
It's not actually necessary to stop the webapp container. IMO nicer to keep it short and omit this 🙂
dizel852
approved these changes
Oct 21, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…8288) * add note to disable basic auth when developing the UI locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Requests from the local webapp development server (running on
localhost:3000) to the local API (running in docker) will fail due to the new basic auth.How
This PR updates the docs around local webapp development, instructing developers to disable basic auth.