update file-secure to 0.2.27 #18500

brianjlai · 2022-10-26T18:40:03Z

source-file was bumped to 0.2.27 in #18481 but we forgot to also bump source-file-secure which will break cloud publish since the connector image will be missing. This fixed that

jdpgrailsdev

brianjlai · 2022-10-26T18:41:17Z

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/3331653056
❌ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/3331653056
🐛 https://gradle.com/s/s5gak3ytl6idu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs2] - Failed: DID NOT RA...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
============ 1 failed, 25 passed, 2 skipped, 27 warnings in 55.11s =============

brianjlai · 2022-10-26T18:59:44Z

i'm actually not sure if source-file-secure is meant to be run in SAT standalone, but given this is trivial i'll try the publish anyway

brianjlai · 2022-10-26T18:59:50Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/3331770235

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

brianjlai · 2022-10-26T20:19:57Z

airbyte-integrations/connectors/source-file-secure/Dockerfile

@@ -9,5 +9,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

-LABEL io.airbyte.version=0.2.26
+LABEL io.airbyte.version=0.2.27


We should also be incrementing FROM airbyte/source-file:0.2.26 to 0.2.27 to correspond to the source-file bump. However, for some reason I haven't been able to figure out immediately, using that version causes a SAT test to fail. The priority is to fix the build pipeline and not introduce a potential security regression so we should use the prior version instead of commenting out the acceptance test.

brianjlai · 2022-10-26T20:20:24Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/3332286523

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

artem1205 · 2022-10-27T08:52:41Z

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/3335933015
✅ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/3335933015
Python tests coverage:

Name                                                                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------------------------------------------------------
source_file_secure/__init__.py                                                                                  2      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/__init__.py       2      0   100%
source_file_secure/source.py                                                                                   45     10    78%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/utils.py          9      4    56%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/source.py        75     46    39%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/client.py       273    208    24%
-------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                         406    268    34%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       125      7    94%   85-87, 91-93, 221
	 source_acceptance_test/conftest.py                     167    167     0%   6-287
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              338    111    67%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 443-452, 483-484, 490, 493, 526-536, 549-574, 579-583
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1451    455    69%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 26 passed, 2 skipped, 27 warnings in 39.64s ==================

artem1205 · 2022-10-27T09:26:19Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/3336171693

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

update file-secure to 0.2.27

bc4e220

brianjlai requested review from artem1205 and jdpgrailsdev October 26, 2022 18:40

github-actions bot added the area/connectors Connector related issues label Oct 26, 2022

octavia-squidington-iv added the connectors/source/file-secure label Oct 26, 2022

jdpgrailsdev approved these changes Oct 26, 2022

View reviewed changes

brianjlai added 2 commits October 26, 2022 13:09

temporarily remove test to unblock the pipeline

cbdd4d2

actually downgrade file instead of comment out a test

9f691de

brianjlai commented Oct 26, 2022

View reviewed changes

artem1205 force-pushed the brian/bump-file-secure branch from c840c77 to 9f691de Compare October 27, 2022 08:51

artem1205 closed this Oct 28, 2022

brianjlai deleted the brian/bump-file-secure branch August 16, 2023 19:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update file-secure to 0.2.27 #18500

update file-secure to 0.2.27 #18500

brianjlai commented Oct 26, 2022

jdpgrailsdev left a comment

brianjlai commented Oct 26, 2022 •

edited by github-actions bot

Loading

brianjlai commented Oct 26, 2022 •

edited

Loading

brianjlai commented Oct 26, 2022 •

edited by github-actions bot

Loading

brianjlai Oct 26, 2022

brianjlai commented Oct 26, 2022 •

edited by github-actions bot

Loading

artem1205 commented Oct 27, 2022 •

edited by github-actions bot

Loading

artem1205 commented Oct 27, 2022 •

edited by github-actions bot

Loading

update file-secure to 0.2.27 #18500

update file-secure to 0.2.27 #18500

Conversation

brianjlai commented Oct 26, 2022

jdpgrailsdev left a comment

Choose a reason for hiding this comment

brianjlai commented Oct 26, 2022 • edited by github-actions bot Loading

Build Failed

brianjlai commented Oct 26, 2022 • edited Loading

brianjlai commented Oct 26, 2022 • edited by github-actions bot Loading

brianjlai Oct 26, 2022

Choose a reason for hiding this comment

brianjlai commented Oct 26, 2022 • edited by github-actions bot Loading

artem1205 commented Oct 27, 2022 • edited by github-actions bot Loading

Build Passed

artem1205 commented Oct 27, 2022 • edited by github-actions bot Loading

brianjlai commented Oct 26, 2022 •

edited by github-actions bot

Loading

brianjlai commented Oct 26, 2022 •

edited

Loading

brianjlai commented Oct 26, 2022 •

edited by github-actions bot

Loading

brianjlai commented Oct 26, 2022 •

edited by github-actions bot

Loading

artem1205 commented Oct 27, 2022 •

edited by github-actions bot

Loading

artem1205 commented Oct 27, 2022 •

edited by github-actions bot

Loading