Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source metabase: allow using only https urls #18607

Merged
merged 5 commits into from
Oct 31, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-metabase/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.2.0
LABEL io.airbyte.name=airbyte/source-metabase
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@ connector_image: airbyte/source-metabase:dev
tests:
spec:
- spec_path: "source_metabase/spec.yaml"
backward_compatibility_tests_config:
disable_for_version: "0.1.0"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
- config_path: "integration_tests/config_http_url.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.0"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"instance_api_url": "http://localhost:3000"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"instance_api_url": "localhost:3000",
"instance_api_url": "https://localhost:3000",
"username": "wrong-account-id",
"password": "2020-05-01T00:00:00Z",
"session_token": "invalid"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-metabase/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from setuptools import find_packages, setup

MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "requests>=2.28.0", "types-requests>=2.27.30"]
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.2", "requests>=2.28.0", "types-requests>=2.27.30"]

TEST_REQUIREMENTS = [
"pytest~=6.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,25 @@
"type": ["null", "integer"]
},
"table": {
"type": ["null", "string"]
"type": ["null", "object"],
"properties": {
"active": {"type": "boolean"},
"caveats": {"type": ["null", "string"]},
"created_at": {"type": ["null", "string"]},
"db_id": {"type": "integer"},
"description": {"type": ["null", "string"]},
"display_name": {"type": ["null", "string"]},
"entity_type": {"type": ["null", "string"]},
"field_order": {"type": ["null", "string"]},
"id": {"type": "integer"},
"initial_sync_status": {"type": ["null", "string"]},
"name": {"type": ["null", "string"]},
"points_of_interest": {"type": ["null", "array"]},
"schema": {"type": ["null", "string"]},
"show_in_getting_started": {"type": "boolean"},
"updated_at": {"type": ["null", "string"]},
"visibility_type": {"type": ["null", "string"]}
}
},
"database_id": {
"type": ["null", "integer"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ connectionSpecification:
URL to your metabase instance API
examples:
- "http://localhost:3000/api/"
pattern: "https://.+"
davydov-d marked this conversation as resolved.
Show resolved Hide resolved
order: 0
username:
type: string
Expand Down
31 changes: 16 additions & 15 deletions docs/integrations/sources/metabase.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,21 @@ This Source is capable of syncing the following Streams:

### Data type mapping

| Integration Type | Airbyte Type | Notes |
| :--- | :--- | :--- |
| `string` | `string` | |
| `integer`, `number` | `number` | |
| `array` | `array` | |
| `object` | `object` | |
| Integration Type | Airbyte Type | Notes |
|:--------------------|:-------------|:------|
| `string` | `string` | |
| `integer`, `number` | `number` | |
| `array` | `array` | |
| `object` | `object` | |

### Features

| Feature | Supported?\(Yes/No\) | Notes |
| :--- | :--- | :--- |
| Full Refresh Sync | Yes | |
| Incremental Sync | No | |
| SSL connection | Yes |
| Namespaces | No | |
| Feature | Supported?\(Yes/No\) | Notes |
|:------------------|:---------------------|:------|
| Full Refresh Sync | Yes | |
| Incremental Sync | No | |
| SSL connection | Yes |
| Namespaces | No | |

## Getting started

Expand Down Expand Up @@ -68,6 +68,7 @@ authenticated query is running, which might trigger security alerts on the user'

## Changelog

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.0 | 2022-06-15 | [6975](https://github.com/airbytehq/airbyte/pull/13752) | Initial (alpha) release |
| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:---------------------------|
| 0.2.0 | 2022-10-28 | [18607](https://github.com/airbytehq/airbyte/pull/18607) | Disallow using `http` URLs |
| 0.1.0 | 2022-06-15 | [6975](https://github.com/airbytehq/airbyte/pull/13752) | Initial (alpha) release |