🎉 New Source: Rocket.chat [low-code cdk]

[haithem-souala]

What

https://developer.rocket.chat/reference/api

How

A new source connector using low-code cdk.

Streams

• "*ref(definitions.teams_stream)"
• "*ref(definitions.rooms_stream)"
• "*ref(definitions.channels_stream)"
• "*ref(definitions.roles_stream)"
• "*ref(definitions.subscriptions_stream)"
• "*ref(definitions.users_stream)"

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub by running the /publish command described here
• After the connector is published, connector added to connector index as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

[marcosmarxm]

Hello @haithem-souala, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

• Make sure you have added connector documentation to /docs/integrations/
• Remove the file catalog from /integration_tests
• Edit the sample_config.json inside /integration_tests
• For the configured_catalog you can use only json_schema: {}
• Add title to all properties in the spec.yaml
• Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
• Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

[vincentkoc]

@haithem-souala see the following integration test results failing:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
=================== 3 failed, 21 passed, 3 skipped in 28.28s ===================

Do you mind taking another look, i used the keys in the repo. When i used my own POC workspace and keys i was able to connect but all the endpoints where failing for me.

[vincentkoc]

@haithem-souala please give me write access to your local branch (https://github.com/airbyte-rocketchat/airbyte/tree/connector/rocket-chat), as i need to make some changes

[haithem-souala]

@haithem-souala please give me write access to your local branch (https://github.com/airbyte-rocketchat/airbyte/tree/connector/rocket-chat), as i need to make some changes

Done!

[vincentkoc]

@haithem-souala additional changes pushed to your branch, tests are still failing do you mind investigating?

[haithem-souala]

@haithem-souala additional changes pushed to your branch, tests are still failing do you mind investigating?

Tests passed, using gradle and python.

[vincentkoc]

@haithem-souala your credentials work, but if i use a clean install (new rocket chat workspace)there are issues and unsure why. Not sure if the tests are setup properly. Will have another look and let you know

[vincentkoc]

/test connector=connectors/source-rocket-chat

🕑 connectors/source-rocket-chat https://github.com/airbytehq/airbyte/actions/runs/3440289346
✅ connectors/source-rocket-chat https://github.com/airbytehq/airbyte/actions/runs/3440289346
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
======================== 24 passed, 3 skipped in 35.05s ========================

maintainer will check the requested changes

[vincentkoc]

/publish connector=connectors/source-rocket-chat run-tests=false

🕑 Publishing the following connectors:
connectors/source-rocket-chat
https://github.com/airbytehq/airbyte/actions/runs/3455157688

Connector	Did it publish?	Were definitions generated?
connectors/source-rocket-chat	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[vincentkoc]

Source definitions manually updated, ready to merge @sajarin

[marcosmarxm]

Thanks @haithem-souala