-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: replace GITHUB_OUTPUT with GITHUB_ENV on multiline variables #18809
Merged
cuyk
merged 2 commits into
master
from
vova/3161-fix-multiline-outputs-in-github-actions
Nov 2, 2022
Merged
ci: replace GITHUB_OUTPUT with GITHUB_ENV on multiline variables #18809
cuyk
merged 2 commits into
master
from
vova/3161-fix-multiline-outputs-in-github-actions
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 20:18
fb001d5
to
d2d087a
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 20:23
d2d087a
to
fbbf84a
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 20:33
fbbf84a
to
a2c8bb0
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 20:51
a2c8bb0
to
8600423
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 20:55
8600423
to
06cf23c
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 21:00
06cf23c
to
ac37557
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 21:13
8b90c7f
to
acc345c
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 21:19
acc345c
to
40762c0
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 21:23
40762c0
to
27a89b7
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 21:42
27a89b7
to
b7ce89b
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 21:55
b7ce89b
to
f24a448
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 22:03
f24a448
to
7eea640
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 22:16
7eea640
to
e07c055
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 22:47
c7f3814
to
3e0224d
Compare
cuyk
changed the title
ci: fix multiline github output in publish-helm-charts
ci: replace GITHUB_OUTPUT with GITHUB_ENV on multiline variables
Nov 1, 2022
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 1, 2022 22:51
3e0224d
to
82941e7
Compare
cuyk
force-pushed
the
vova/3161-fix-multiline-outputs-in-github-actions
branch
from
November 2, 2022 07:40
82941e7
to
f76deca
Compare
c-p-b
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
drewrasm
pushed a commit
to drewrasm/airbyte
that referenced
this pull request
Nov 2, 2022
…bytehq#18809) * ci: replace GITHUB_OUTPUT with GITHUB_ENV on multiline variables * ci: replace github set-ouput with new syntax in ./tools/bin/
arsenlosenko
pushed a commit
that referenced
this pull request
Nov 8, 2022
* solve conflicts * solve conflict in json schema * bump to version 0.1.8 for the changes of this pr * change ad account id in the schemas * query to include data plane attributes (#18531) * query to include data plane attributes * rename functions * fix java build * more renaming fix * Fix unit tests in source relational db (#18789) * Fix unit tests * Add extra test case for record count > 1 * Store record count in variable * ci: use custom test-reporter action to upload job results (#18004) * ci: use custom action to upload job results * Correct coinmarket spec (#18790) * correct coinmarket spec * remove duplicate support normalization from source spec * rollback coinmarketcap version in source def seed * update connector version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * Parameterize test_empty_streams and test_stream_with_1_airbyte_column by destination (#18197) * Remove lines that always add Postgres to list of destinations * Parameterize all tests in test_ephemeral by destination * 🐛 Source Facebook Marketing: reduce request limit after specific error (#18734) * 🐛 Source Facebook Marketing: reduce request limit after specific error * 🐛 Source Facebook Marketing: bump version; update docs * 🐛 Source Facebook Marketing: add test * 🐛 Source Facebook Marketing: increase timeout * [charts/airbyte-cron] Cleanup env vars (#18787) * [charts/airbyte-cron] Cleanup env vars * Remove unused env var * Use equalsIgnoreCase (#18810) * Bump helm chart version reference to 0.40.40 (#18815) Co-authored-by: perangel <perangel@users.noreply.github.com> Co-authored-by: Kyryl Skobylko <xpuska513@gmail.com> * 🐛Destination Google Sheets: Fix empty headers list (#18729) * Fix empty headers list * Updated PR number * Bumped version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * 🐛Source Exchange Rates: Fix handling error during check connection (#18726) * Fix handling error during check connection * Updated PR number * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * Add normalization changelog and bump normalization version in platform (#18813) * Remove ConfigPersistence usage from SecretsMigrator (#18747) * remove config persistence from seeding logic (#18749) * Remove the bulk actions from ConfigPersistence (#18800) * hide ConfigPersistence inside ConfigRepository to discourage use (#18803) * ci: add job and run id to test reports (#18832) * Bump Airbyte version from 0.40.17 to 0.40.18 (#18827) Co-authored-by: grishick <grishick@users.noreply.github.com> * 🪟🔧 Remove styled components (round 1) (#18766) * refactor EditorHeader (untested) * refactor BaseClearView * delete unused Subtitle * refactor ConfirmationModal * refactor Arrow * refactor BulkHeader * refactor CatalogTreeSearch * refactor StreamFieldTable * refactor StreamHeader * refactor ConnectorIcon * refactor TreeRowWrapper * refactor DeleteBlock * refactor EmptyResourceBlock * revert unintended element change * fixed acceptance tests (#18699) * 🪟🔧 Reactor Breadcrumbs component to use anchors (#18764) * refactor breadcrumbs to use actual links * PR comments on styles * increase test timeout for some webapp tests to prevent flakes (#18807) * Remove "Filters and Segments" from Google Analytics v4 (#18508) Filters and Segments info was incorrectly added to the Google Analytics v4 connector instead of the Google Analytics (Universal Analytics) Connector. * Add notes about EU OAUth (#18835) EU OAuth is not fully tested so adding a note to account for that. * 🪟🐛 Fix: visual regression in ConnectorIcon (#18849) * fix visual regression * remove unused prop * Add links to demo page (#18828) * mysql-source:fix tinyint unsigned handling (#18619) * mysql-source:fix tinyint unsigned handling * update doc * format * upgrade version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * 🪟 🎉 Allow environment specific sections in docs (#18829) * Allow environment specific sections in docs * Change syntax to lower case * ci: replace GITHUB_OUTPUT with GITHUB_ENV on multiline variables (#18809) * ci: replace GITHUB_OUTPUT with GITHUB_ENV on multiline variables * ci: replace github set-ouput with new syntax in ./tools/bin/ * Add connection ID to span (#18852) * edited connector docs (#18855) * 🪟 🔧 Upgrade husky to 8.0.1 (#18719) * Upgrade Husky * Upgrade Husky * Upgrade Husky * Upgrade Husky * Upgrade Husky * ci: replace GITHUB_OUTPUT with GITHUB_ENV for multiline variables (#18857) * Avoid NPE when adding connection ID to trace (#18856) * Filter exit errors by operation name (#18850) * add label * auto-bump connector version Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Xiaohan Song <xiaohan@airbyte.io> Co-authored-by: Liren Tu <tuliren@gmail.com> Co-authored-by: Conor <cpdeethree@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Greg Solovyev <grishick@users.noreply.github.com> Co-authored-by: Artem Inzhyyants <36314070+artem1205@users.noreply.github.com> Co-authored-by: perangel <perangel@gmail.com> Co-authored-by: Jonathan Pearlin <jonathan@airbyte.io> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: perangel <perangel@users.noreply.github.com> Co-authored-by: Kyryl Skobylko <xpuska513@gmail.com> Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com> Co-authored-by: Charles <charles@airbyte.io> Co-authored-by: Octavia Squidington III <90398440+octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Joey Marshment-Howell <josephkmh@users.noreply.github.com> Co-authored-by: darynaishchenko <80129833+darynaishchenko@users.noreply.github.com> Co-authored-by: Michael Siega <109092231+mfsiega-airbyte@users.noreply.github.com> Co-authored-by: Tyler B <104733644+TBernstein4@users.noreply.github.com> Co-authored-by: Yowan Ramchoreeter <26179814+YowanR@users.noreply.github.com> Co-authored-by: Tim Roes <tim@airbyte.io> Co-authored-by: Subodh Kant Chaturvedi <subodh1810@gmail.com> Co-authored-by: Volodymyr Pochtar <v.pochtar@gmail.com> Co-authored-by: Amruta Ranade <11484018+Amruta-Ranade@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
$GITHUB_OUTPUT in GitHub Actions doesn't work correctly with multiline variables.
How
Replace $GITHUB_OUTPUT with $GITHUB_ENV on multiline strings.