Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source RD Station Marketing: Fix stream analytics conversions #18826

Merged
merged 8 commits into from
Dec 5, 2022
Merged

🐛 Source RD Station Marketing: Fix stream analytics conversions #18826

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b077e2d
Fix stream analytics conversions on RD Station Marketing
sarafonseca-123 Nov 1, 2022
0857d9c
update connector's version
sarafonseca-123 Nov 1, 2022
f16a5c5
Merge branch 'master' into fix-rd-station
sarafonseca-123 Nov 1, 2022
679b22e
Fix PR number on changelog
sarafonseca-123 Nov 1, 2022
c4d59c5
Merge branch 'fix-rd-station' of https://github.com/sarafonseca-123/a…
sarafonseca-123 Nov 1, 2022
6219bd8
Merge branch 'master' into fix-rd-station
sarafonseca-123 Nov 7, 2022
0cce612
auto-bump connector version
octavia-squidington-iii Nov 7, 2022
5e6ed17
Merge branch 'master' into fix-rd-station
sarafonseca-123 Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-rd-station-marketing/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_rd_station_marketing ./source_rd_station_marketing
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/source-rd-station-marketing
4 changes: 0 additions & 4 deletions ...ntegrations/connectors/source-rd-station-marketing/source_rd_station_marketing/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,6 @@ class AnalyticsConversions(IncrementalRDStationMarketingStream):
cursor_field = "asset_updated_at"
primary_key = "asset_id"

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
records = response.json().get(self.data_field)[0].get(self.data_field)
yield from records


class AnalyticsEmails(IncrementalRDStationMarketingStream):
"""
Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/rd-station-marketing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@ Each endpoint has its own performance limitations, which also consider the accou

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :-------------------------------------------------------------- |
| 0.1.0 | 2022-10-23 | [18348](https://github.com/airbytehq/airbyte/pull/18348) | Initial Release |
| 0.1.1 | 2022-11-01 | [18826](https://github.com/airbytehq/airbyte/pull/18826) | Fix stream analytics_conversions |
| 0.1.0 | 2022-10-23 | [18348](https://github.com/airbytehq/airbyte/pull/18348) | Initial Release |