Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating InvalidCursorException -> ConfigErrorException #18995

Merged
merged 6 commits into from
Nov 4, 2022
Merged

Migrating InvalidCursorException -> ConfigErrorException #18995

merged 6 commits into from
Nov 4, 2022

Conversation

akashkulk
Copy link
Contributor

Breaking off this PR: #18560
into smaller pieces.

Migrating InvalidCursorException to ConfigErrorException and cleaning up config error handling code in AbstractDbSource

@akashkulk akashkulk requested a review from a team as a code owner November 4, 2022 21:53
@akashkulk akashkulk requested a review from rodireich November 4, 2022 21:53
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 4, 2022
@akashkulk
Copy link
Contributor Author

akashkulk commented Nov 4, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3397333785
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3397333785
No Python unittests run

Build Passed

Test summary info:

All Passed

@akashkulk
Copy link
Contributor Author

akashkulk commented Nov 4, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3397334092
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3397334092
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022 •
edited
Loading

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector version
  • Add changelog
  • Publish the new version

⚠ Sources (24)
Connector Version Changelog Publish
source-alloydb 1.0.17 ✅ ✅
source-alloydb-strict-encrypt 1.0.17 ✅ ⚠
(not in seed)
source-bigquery 0.2.3 ✅ ✅
source-clickhouse 0.1.14 ✅ ✅
source-clickhouse-strict-encrypt 0.1.14 ✅ ⚠
(not in seed)
source-cockroachdb 0.1.18 ✅ ✅
source-cockroachdb-strict-encrypt 0.1.18 ✅ ⚠
(not in seed)
source-db2 0.1.16 ✅ ✅
source-db2-strict-encrypt 0.1.16 ✅ ⚠
(not in seed)
source-jdbc 0.3.5 ⚠
(doc not found)		 ⚠
(not in seed)
source-mongodb-strict-encrypt 0.1.19 ⚠
(doc not found)		 ⚠
(not in seed)
source-mongodb-v2 0.1.19 ✅ ✅
source-mssql 0.4.25 ✅ ✅
source-mssql-strict-encrypt 0.4.25 ✅ ⚠
(not in seed)
source-mysql 1.0.11 ✅ ✅
source-mysql-strict-encrypt 1.0.11 ✅ ⚠
(not in seed)
source-oracle 0.3.21 ✅ ✅
source-oracle-strict-encrypt 0.3.21 ✅ ⚠
(not in seed)
source-postgres 1.0.22 ✅ ✅
source-postgres-strict-encrypt 1.0.22 ✅ ⚠
(not in seed)
source-redshift 0.3.15 ✅ ✅
source-scaffold-java-jdbc 0.1.0 ⚠
(doc not found)		 ⚠
(not in seed)
source-snowflake 0.1.24 ✅ ✅
source-tidb 0.2.1 ✅ ✅
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)
Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)
Category Status Actionable Item
Version ❌
mismatch		 The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing		 There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed		 The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version		 The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@akashkulk akashkulk temporarily deployed to more-secrets November 4, 2022 21:54 Inactive
@akashkulk akashkulk changed the title Invalid cursor refac Migrating InvalidCursorException -> ConfigErrorException Nov 4, 2022
@akashkulk akashkulk temporarily deployed to more-secrets November 4, 2022 21:57 Inactive
@akashkulk akashkulk merged commit a53b947 into master Nov 4, 2022
@akashkulk akashkulk deleted the invalid_cursor_refac branch November 4, 2022 23:14
letiescanciano added a commit that referenced this pull request Nov 7, 2022
@letiescanciano
Merge branch 'master' into leti/experiment-add-source-in-signup
c3edfb7 
* master: (69 commits)
  🪟 🐛 Fix wrong geography dropdown type #19021
  SAT: basic read on full catalog when `test_strictness_level == high` (#18937)
  Unhide DynamoDB destination (#18994)
  Fixed tests for destination connectors (#19007)
  🐛 Source Facebook Marketing: handle FacebookBadObjectError (#18971)
  Edit multi-cloud docs (#18972)
  🪟 🎉 Load credits consumption separate (#18986)
  Bmoric/extract source api (#18944)
  Migrating InvalidCursorException -> ConfigErrorException  (#18995)
  🪟 🎨 Fix banner link color (#18978)
  Handling configuration exceptions in IntegrationRunner (#18989)
  Add new workspace api endpoint (#18983)
  Add normalization to destination definition and actor definition table (#18300)
  Fix oauth controller (#18981)
  Fix migration dev center schema dump by run db-specific initialization script (#18984)
  fix master build failure (#18982)
  cleanup: delete debezium 1-4-2 module (#18733)
  Remove unused job persistence methods. (#18952)
  Hash filenames of extracted CSS (#18976)
  Fix typo in source code comment DataDaog ==> Datadog (#18911)
  ...
letiescanciano added a commit that referenced this pull request Nov 7, 2022
@letiescanciano
Merge branch 'master' into leti/move-oauth-to-the-top
6c7a97f 
* master: (73 commits)
  🪟 🐛 Fix wrong geography dropdown type #19021
  SAT: basic read on full catalog when `test_strictness_level == high` (#18937)
  Unhide DynamoDB destination (#18994)
  Fixed tests for destination connectors (#19007)
  🐛 Source Facebook Marketing: handle FacebookBadObjectError (#18971)
  Edit multi-cloud docs (#18972)
  🪟 🎉 Load credits consumption separate (#18986)
  Bmoric/extract source api (#18944)
  Migrating InvalidCursorException -> ConfigErrorException  (#18995)
  🪟 🎨 Fix banner link color (#18978)
  Handling configuration exceptions in IntegrationRunner (#18989)
  Add new workspace api endpoint (#18983)
  Add normalization to destination definition and actor definition table (#18300)
  Fix oauth controller (#18981)
  Fix migration dev center schema dump by run db-specific initialization script (#18984)
  fix master build failure (#18982)
  cleanup: delete debezium 1-4-2 module (#18733)
  Remove unused job persistence methods. (#18952)
  Hash filenames of extracted CSS (#18976)
  Fix typo in source code comment DataDaog ==> Datadog (#18911)
  ...
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodireich rodireich rodireich approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/postgres connectors/source/relational-db
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akashkulk @rodireich @octavia-squidington-iv