🪟 🐛 Update refresh schema logic to handle confirmation modal and other edge cases #19131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnaglick
reviewed
Nov 9, 2022
airbyte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPage/ConnectionReplicationTab.tsx
Show resolved
Hide resolved
edmundito
force-pushed
the
edmundito/refresh-discard-confirmation
branch
from
47df903 to
24b22d9
Compare
edmundito
changed the title
airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEditService.tsx
Show resolved
Hide resolved
airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEditService.tsx
Show resolved
Hide resolved
airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEditService.tsx
Show resolved
Hide resolved
krishnaglick
approved these changes
Nov 23, 2022
* Update the refresh schema separately * Only mark as refreshed if the syncCatalog has changed * Add option to clear refreshed schema * Update tests
* ConnectionEditService now marks schema as refreshed only if the catalog has changed, clears refresh after schema update * Add mockCatalog diff and add refresh schema tests to connection edit service * Add interfaces to useConnectionEdit and useConnectionForm to better track references * Remove clearRefreshedSchema from ConnectionReplicationTab form submit * Update useConfirmCatalogDiff to only show if the diff has changed, instead of the whole connection
edmundito
force-pushed
the
edmundito/refresh-discard-confirmation
branch
from
8c3565c to
fe85b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change ensures that:
catalogIdare discarded when the user cancels or navigates away from the pageSome of this functionality was lost during the refactor in #15603
How
The connection sync catalog and the schema are stored when the hook is initialized so that they can be reset if the user cancels or navigates away from the tab. These are only updated when the syncCatalog is updated.
Additionally, I updated the tests to check for diffs and added additional interfaces to track references of hook usage better.
Recommended reading order
airbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEditService.tsxairbyte-webapp/src/hooks/services/ConnectionEdit/ConnectionEditService.test.tsxRest of code