Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🧪E2E testing: DB data manipulation + Catalog Diff modal test cases #19447

Merged
merged 21 commits into from
Nov 28, 2022
Merged

🪟 🧪E2E testing: DB data manipulation + Catalog Diff modal test cases #19447

merged 21 commits into from
Nov 28, 2022

Conversation

dizel852
Copy link
Contributor

@dizel852 dizel852 commented Nov 15, 2022 •
edited
Loading

What

Resolves 19430

How

Adds integration with covering Catalog Diff modal cases:

  • new stream is added
  • stream is removed
  • a stream has changed: some columns were removed and some were added

Cypress test run: https://dashboard.cypress.io/projects/916nvw/runs/14637/overview

The whole test case:

  1. Create a connection Postgres => Local JSON
  2. Change data in DB
  3. Open connections settings (Replication Tab)
  4. Click the "Refresh Source Schema" button
  5. 💡 Catalog Diff modal should appear
  6. Select newly added stream
  7. Click the "Save changes" button
  8. 💡 "Stream configuration changed" modal should appear
  9. Confirm reset
  10. Remove the created connection
  11. Clean DB from populated data
  • add utility functions for manipulation(create, update delete) data in Postgres DB directly from test run

Screenshot at Nov 16 02-23-20

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 16, 2022
@dizel852
remove 'only' flag
e3b09c0
@dizel852
Merge branch 'master' into e2e-diff-modal-test-cases
cfd0ed3 
# Conflicts:
#	airbyte-webapp/src/views/Connection/CatalogDiffModal/useConfirmCatalogDiff.tsx
@dizel852 dizel852 marked this pull request as ready for review November 16, 2022 12:50
@dizel852 dizel852 requested a review from a team as a code owner November 16, 2022 12:50
@dizel852 dizel852 changed the title 🪟 🧪 E2E testing: DB manipulation + Diff modal test cases 🪟 🧪 E2E testing: DB data manipulation + Catalog Diff modal test cases Nov 16, 2022
@krishnaglick krishnaglick self-requested a review November 16, 2022 18:02
krishnaglick
krishnaglick approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I did not test locally but given this is an addition to CI I imagine CI will let us know if there's an issue ;)

airbyte-webapp-e2e-tests/cypress/plugins/index.ts
/**
* @type {Cypress.PluginConfig}
*/
module.exports = (on, config) => {
module.exports = (on: Cypress.PluginEvents, config: Cypress.PluginConfigOptions) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

SofiiaZaitseva
SofiiaZaitseva approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@SofiiaZaitseva SofiiaZaitseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@dizel852 dizel852 changed the title 🪟 🧪 E2E testing: DB data manipulation + Catalog Diff modal test cases 🪟 🧪[CodeFreeze][ReadyToMerge] E2E testing: DB data manipulation + Catalog Diff modal test cases Nov 21, 2022
@dizel852 dizel852 mentioned this pull request Nov 22, 2022
Merged
@dizel852 dizel852 changed the title 🪟 🧪[CodeFreeze][ReadyToMerge] E2E testing: DB data manipulation + Catalog Diff modal test cases 🪟 🧪E2E testing: DB data manipulation + Catalog Diff modal test cases Nov 28, 2022
@dizel852 dizel852 merged commit 66edbfb into master Nov 28, 2022
@dizel852 dizel852 deleted the e2e-diff-modal-test-cases branch November 28, 2022 16:19
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SofiiaZaitseva SofiiaZaitseva SofiiaZaitseva approved these changes

@krishnaglick krishnaglick krishnaglick approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/platform-move
Projects
None yet
Milestone
No milestone
4 participants
@dizel852 @krishnaglick @SofiiaZaitseva @octavia-squidington-iv