[18713] Destination-bigquery: updated Check method to test for non-billable project #19489

etsybaev · 2022-11-16T16:34:50Z

Closes:
#18713
https://github.com/airbytehq/oncall/issues/896
https://github.com/airbytehq/oncall/issues/1030

What

Airbyte sync and normalization actions use a lot of different features of BigQuery.
Unfortunately, the BigQuery service works with many limitations for non-billable projects. So airbyte users were able to pass the check connection stage, but then sync fails in the middle.

Common issues were:

"Billing has not been enabled for this project. Enable billing at https://console.cloud.google.com/billing. DML queries are not allowed in the free tier. Set up a billing account to remove this restriction."
"Access Denied: BigQuery BigQuery: Streaming insert is not allowed in the free tier"
etc

For more details please also check:
https://cloud.google.com/bigquery/docs/streaming-data-into-bigquery
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-manipulation-language

How

Added additional verification to the Check() connection method. These changes should also cover more possible permissions issues that we didn't cover on the check method in the past.

Tested with local deployment

🚨 User Impact 🚨

No breaking changes expected

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…llable project

etsybaev · 2022-11-16T16:35:25Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3481256048
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3481256048
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

github-actions · 2022-11-16T16:36:06Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

⚠ Destinations (2)

Connector	Version	Changelog	Publish
`destination-bigquery`	`1.2.8`	✅	✅
`destination-bigquery-denormalized`	`1.2.8`	⚠ (doc not found)	✅

See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

base-normalization

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

grishick · 2022-11-16T17:49:37Z

...ation-bigquery/src/main/java/io/airbyte/integrations/destination/bigquery/BigQueryUtils.java

-    final Dataset dataset = bigquery.getDataset(tmpTestDatasetId);
+    final DatasetInfo datasetInfo = DatasetInfo.newBuilder(tmpTestDatasetId).setLocation(datasetLocation).build();
+
+    bigquery.create(datasetInfo);


if bigquery.create(datasetInfo) fails - do we report a config error or a runtime error?

Yes, it should be handled by Catch in IntegrationRunner class. Basically, like any other exception. But we may catch it explicitly if needed. Should I update the PR?

etsybaev · 2022-11-16T17:50:12Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3481813751
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3481813751
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

…project-for-billing

etsybaev · 2022-11-21T19:40:32Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3517581582
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3517581582
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-11-21T20:41:09Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3517970976
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3517970976
🐛 https://gradle.com/s/fm64rmhjodvey

Build Failed

Test summary info:

Could not find result summary

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3517970976
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3517970976
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

etsybaev · 2022-11-22T09:31:28Z

/publish connector=connectors/destination-bigquery

🕑 Publishing the following connectors:
connectors/destination-bigquery
https://github.com/airbytehq/airbyte/actions/runs/3522091013

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

etsybaev · 2022-11-22T11:02:00Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 Publishing the following connectors:
connectors/destination-bigquery-denormalized
https://github.com/airbytehq/airbyte/actions/runs/3522765162

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery-denormalized	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[18713] Destination-bigquery: updated Check method to test for non-bi…

f02b8ae

…llable project

octavia-squidington-iv added area/connectors Connector related issues connectors/destination/bigquery labels Nov 16, 2022

etsybaev marked this pull request as ready for review November 16, 2022 17:35

etsybaev linked an issue Nov 16, 2022 that may be closed by this pull request

Destination Bigquery: Check should verify something about billing #18713

Closed

grishick reviewed Nov 16, 2022

View reviewed changes

fixed typo in comments

aa7db1c

etsybaev requested a review from grishick November 16, 2022 18:43

grishick approved these changes Nov 21, 2022

View reviewed changes

Merge branch 'master' into etsybaev/18713-destination-bigquery-check-…

aa80756

…project-for-billing

Bumped version

b67f7d0

octavia-squidington-iv added area/documentation Improvements or additions to documentation connectors/destination/bigquery-denormalized labels Nov 22, 2022

auto-bump connector version

e32a2be

octavia-squidington-iii temporarily deployed to more-secrets November 22, 2022 10:27 Inactive

octavia-squidington-iii temporarily deployed to more-secrets November 22, 2022 10:29 Inactive

auto-bump connector version

77a01f5

octavia-squidington-iii temporarily deployed to more-secrets November 22, 2022 11:42 Inactive

octavia-squidington-iii temporarily deployed to more-secrets November 22, 2022 13:00 Inactive

octavia-squidington-iii temporarily deployed to more-secrets November 22, 2022 13:01 Inactive

octavia-squidington-iii temporarily deployed to more-secrets November 22, 2022 14:05 Inactive

grishick merged commit be530bb into master Nov 28, 2022

grishick deleted the etsybaev/18713-destination-bigquery-check-project-for-billing branch November 28, 2022 17:36

github-actions bot mentioned this pull request Nov 28, 2022

Bump helm chart version reference to 0.42.2 #19839

Closed

octavia-squidington-iii mentioned this pull request Nov 30, 2022

Bump Airbyte version from 0.40.22 to 0.40.23 #19941

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18713] Destination-bigquery: updated Check method to test for non-billable project #19489

[18713] Destination-bigquery: updated Check method to test for non-billable project #19489

etsybaev commented Nov 16, 2022 •

edited

Loading

etsybaev commented Nov 16, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 16, 2022 •

edited

Loading

✅ Sources (0)

⚠ Destinations (2)

👀 Other Modules (1)

Actionable Items

grishick Nov 16, 2022 •

edited

Loading

etsybaev Nov 16, 2022 •

edited

Loading

etsybaev commented Nov 16, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 21, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 21, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 22, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 22, 2022 •

edited by github-actions bot

Loading

[18713] Destination-bigquery: updated Check method to test for non-billable project #19489

[18713] Destination-bigquery: updated Check method to test for non-billable project #19489

Conversation

etsybaev commented Nov 16, 2022 • edited Loading

What

How

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

etsybaev commented Nov 16, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Nov 16, 2022 • edited Loading

Affected Connector Report

✅ Sources (0)

⚠ Destinations (2)

👀 Other Modules (1)

Actionable Items

grishick Nov 16, 2022 • edited Loading

Choose a reason for hiding this comment

etsybaev Nov 16, 2022 • edited Loading

Choose a reason for hiding this comment

etsybaev commented Nov 16, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Nov 21, 2022 • edited by github-actions bot Loading

Build Passed

etsybaev commented Nov 21, 2022 • edited by github-actions bot Loading

Build Failed

Build Passed

etsybaev commented Nov 22, 2022 • edited by github-actions bot Loading

etsybaev commented Nov 22, 2022 • edited by github-actions bot Loading

etsybaev commented Nov 16, 2022 •

edited

Loading

etsybaev commented Nov 16, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 16, 2022 •

edited

Loading

grishick Nov 16, 2022 •

edited

Loading

etsybaev Nov 16, 2022 •

edited

Loading

etsybaev commented Nov 16, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 21, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 21, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 22, 2022 •

edited by github-actions bot

Loading

etsybaev commented Nov 22, 2022 •

edited by github-actions bot

Loading