🪟🎉 Remove the onboarding page #19539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
timroes
commented
Nov 17, 2022
| @@ -202,48 +201,15 @@ | |||
| "preferences.unsubscribeAnyTime": " You can unsubscribe any time.", | |||
| "preferences.securityUpdates": "Receive emails about security updates.", | |||
|
|
|||
| "onboarding.headTitle": "Get Started!", | |||
| "onboarding.title": "Let’s set up your first connection.", | |||
| "onboarding.subtitle": "Connections are automated data pipelines that sync data from a source to a destination.", | |||
| "onboarding.createSource": "Create a source", | |||
There was a problem hiding this comment.
ℹ️ I did check all strings individually here, and the remaining strings are still used across the product (but we could change their IDs in a future PR if we want).
josephkmh
approved these changes
Nov 17, 2022
This was referenced Nov 17, 2022
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Remove the onboarding page * Fix e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the onboarding page from the product. We've run some extensive experiment and had the onboarding page disabled for 50% of all users in the past month(s). We did not see that the onboarding page had any impact on users actually succeeding to setup their connection (or other metrics we track). Thus we decided to remove it from the product and instead focus on improving onboarding flows in the future via other parts of the app (e.g. the already improved empty Connection page). This change was signed off by Natalie and Andy J.
How?
I also ran
ts-pruneand compared the before state to after to make sure there are no new orphaned components that are no longer needed.