Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - added missing vars in .env files #19558

Closed
wants to merge 2 commits into from

Conversation

NivEz
Copy link

@NivEz NivEz commented Nov 17, 2022

What

airbyte worker pod was stuck in pending status due to missing environment variables that were consumed in the worker.yaml file.
The errors:

Error: couldn't find key SHOULD_RUN_NOTIFY_WORKFLOWS in ConfigMap airbyte/airbyte-env-47hsgt13t8
Error: couldn't find key MAX_NOTIFY_WORKERS in ConfigMap airbyte/airbyte-env-bgh1g18g9q

How

Added the missing variables (SHOULD_RUN_NOTIFY_WORKFLOWS and MAX_NOTIFY_WORKERS) to the .env files that is used for generating the configMap.

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2022

CLA assistant check
All committers have signed the CLA.

@NivEz NivEz changed the title added missing vars in .env files fix - added missing vars in .env files Nov 17, 2022
@marcosmarxm
Copy link
Member

Hello 👋, first thank you for this amazing contribution.

We really appreciate the effort you've made to improve the project.
We ask you patience for the code review. Last month our team was focused on Hacktoberfest event and that probably left some PR without the proper feedback. And this week, due to the Thanksgiving US Holiday, most our team is out of office with their families. Another important piece of information why code won't be merge this week is: as a safety measure the core team has decided to freeze merging code to main branch to keep the release stable. Next week we'll return to you with the proper code review and update the status of your contribution.

If you have any questions feel free to send me a message in Slack!
Thanks!

@marcosmarxm
Copy link
Member

Sorry the delay @NivEz it was fixed in #19554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants