🪟 🧪 Make sure to filter out connectors correctly #19732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
lmossman
approved these changes
Nov 22, 2022
| select: (data) => { | ||
| const filteredConnectors = getExcludedConnectorIds(); |
There was a problem hiding this comment.
nit: rename this variable to excludedConnectorIds. When I read the word filtered, I'm never sure if it means the things that were "filtered out", or if it means what is remaining after other things have been filtered out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the connector sign up experiment to properly filter connectors in that file. Earlier the
filtermethod was simply checking if the return value of thegetExcludedConnectorIdsmethod was falsey for filtering out (which it never would be).cc @letiescanciano sorry I apparently reviewed this sloppily and this slipped the review. I disabled the experiment until we have this merged next week.