-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve normalization close error message #19829
Improve normalization close error message #19829
Conversation
…ub.com:airbytehq/airbyte into jonathan/improve-normalization-close-error-msg
...ommons-worker/src/main/java/io/airbyte/workers/normalization/DefaultNormalizationRunner.java
Outdated
Show resolved
Hide resolved
...ommons-worker/src/main/java/io/airbyte/workers/normalization/DefaultNormalizationRunner.java
Outdated
Show resolved
Hide resolved
…ub.com:airbytehq/airbyte into jonathan/improve-normalization-close-error-msg
I believe this merge is causing my Connections to fail during normalization. The error message isn't descriptive in the logs but this is the only merge that dealt with normalization in the last release which is where my Connections are failing. They fail at different points in the transformation for every single connection. My guess is that it is related to the waiting for one minute to throw the error? |
@edgao looks like this is causing failures for an OSS user - @Aggiekev . Their instance is K8 on GKE, logs attached below. |
@jdpgrailsdev do you recognize what's happening in that sync? It looks like normalization terminates cleanly (
|
@edgao There was an issue introduced before this PR that caused a failure when attempting to stop/close the process. This was due to calling |
What
How
Recommended reading order
DefaultNormalizationRunner.java
Tests