🪟 🎨 Update text describing connection geography #19879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
josephkmh
commented
Nov 29, 2022
| @@ -29,8 +29,10 @@ export const links = { | |||
| webhookVideoGuideLink: "https://www.youtube.com/watch?v=NjYm8F-KiFc", | |||
| webhookGuideLink: `${BASE_DOCS_LINK}/operator-guides/configuring-sync-notifications/`, | |||
| cronReferenceLink: "http://www.quartz-scheduler.org/documentation/quartz-2.3.0/tutorials/crontrigger.html", | |||
| cloudAllowlistIPsLink: `${BASE_DOCS_LINK}/cloud/getting-started-with-airbyte-cloud/#allowlist-ip-address`, | |||
| cloudAllowlistIPsLink: `${BASE_DOCS_LINK}/cloud/getting-started-with-airbyte-cloud/#allowlist-ip-addresses`, | |||
There was a problem hiding this comment.
I noticed the URL for the docs was changed as well - not 404-ing, but the link to the heading was broken 🙂
timroes
reviewed
Nov 29, 2022
...pp/src/components/connection/UpdateConnectionDataResidency/UpdateConnectionDataResidency.tsx
Outdated
Show resolved
Hide resolved
timroes
approved these changes
Dec 1, 2022
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the text describing what a connection's geography setting means. This was a suggestion from @alex-gron that @andyjih approved ✅
Before:
After:
This appears on both the connection creation page and on the settings tab of existing connections:
