Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Gitlab: fix stream schema #19986

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

davydov-d
Copy link
Collaborator

What

#12901

How

Change date-time format to date

@davydov-d davydov-d linked an issue Dec 1, 2022 that may be closed by this pull request
@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab labels Dec 1, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 1, 2022

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3594598594
❌ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3594598594
🐛 https://gradle.com/s/i62nedba7i4qq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - ...
============= 1 failed, 30 passed, 31 warnings in 62.17s (0:01:02) =============

@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 1, 2022

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3594834509
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3594834509
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     199     93    53%   35, 41-43, 48, 53, 59, 65, 71, 77-79, 98, 103-105, 111-113, 119-120, 125-126, 131, 137, 146-155, 161-166, 181, 205, 236, 242, 250-255, 263-268, 276-289, 294-300, 307-318, 325-341
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1569    350    78%

Build Passed

Test summary info:

All Passed

@davydov-d davydov-d requested a review from artem1205 December 1, 2022 17:56
@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 1, 2022

/publish connector=connectors/source-gitlab

🕑 Publishing the following connectors:
connectors/source-gitlab
https://github.com/airbytehq/airbyte/actions/runs/3595323317


Connector Did it publish? Were definitions generated?
connectors/source-gitlab

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 1, 2022 18:38 Inactive
@davydov-d davydov-d merged commit 5da3a7c into master Dec 1, 2022
@davydov-d davydov-d deleted the ddavydov/#12901-source-gitlab-fix-schema branch December 1, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Gitlab: expects date-time but returns date
4 participants